CPM: revised unclean exit watching, revised renderer crash test

chrome/browser/performance_monitor/constants.cc

Index: chrome/browser/performance_monitor/constants.cc
diff --git a/chrome/browser/performance_monitor/constants.cc b/chrome/browser/performance_monitor/constants.cc
index 298b9bc467c7aac6b7cbc5d3e07eaf8e1a985526..0b91160d11f8d88f9e27442d347e9edec53da832 100644
--- a/chrome/browser/performance_monitor/constants.cc
+++ b/chrome/browser/performance_monitor/constants.cc
@@ -6,22 +6,44 @@
 
 namespace performance_monitor {
 
-// The key to insert/retrieve information about the chrome version from the
-// database.
-const char kStateChromeVersion[] = "chrome_version";
-const char kMetricNotFoundError[] = "Mertic details not found.";
+// TODO(chebert): i18n on all constants.
+
+// The error message displayed when a metric's details are not found.
+const char kMetricNotFoundError[] = "Metric details not found.";
+
+// Any metric that is not associated with a specific activity will use this as
+// its activity.
 const char kProcessChromeAggregate[] = "chrome_aggregate";
 
+// The interval at which PerformanceMonitor performs its timed collections.
+const int kGatherIntervalInMinutes = 2;
+
+// Tokens to retrieve state values from the database.
+
+// Stores information about the previous chrome version.
+const char kStateChromeVersion[] = "chrome_version";
+// The prefix to the state of a profile's name, to prevent any possible naming
+// collisions in the database.
+const char kStateProfilePrefix[] = "profile";
+
+// Metric details follow.
+// All metric details have the following constants:
+// - Name
+// - Description
+// - Units
+// - TickSize (the smallest possible maximum which will be viewed in the ui.)
+
+// CPU Usage
 const char kMetricCPUUsageName[] = "CPU Usage";
 const char kMetricCPUUsageDescription[] = "The CPU usage measured in percent.";
 const char kMetricCPUUsageUnits[] = "percent";
 const double kMetricCPUUsageTickSize = 100.0;
 
+// Private Memory Usage
 const char kMetricPrivateMemoryUsageName[] = "Private Memory Usage";
 const char kMetricPrivateMemoryUsageDescription[] =
     "The private memory usage measured in bytes.";
 const char kMetricPrivateMemoryUsageUnits[] = "percent";
 const double kMetricPrivateMemoryUsageTickSize = 10000000.0;
 
-
 }  // namespace performance_monitor