Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 10815075: Status area notification appearance tweaks. (Closed)

Created:
8 years, 5 months ago by stevenjb
Modified:
8 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Status area notification appearance tweaks. BUG=137139, 137137, 137136 TEST=See issues. Ensure web notifications look and appear properly. For ash grd change: TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148326

Patch Set 1 #

Patch Set 2 : Rebase after 10800103 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -31 lines) Patch
M ash/ash_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_notification_view.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 7 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
stevenjb
A few relatively small/simple fixes to the status area notification appearances. Ready for review.
8 years, 5 months ago (2012-07-24 18:35:45 UTC) #1
sadrul
LGTM (assuming the image lands with or before this CL)
8 years, 5 months ago (2012-07-24 18:38:42 UTC) #2
stevenjb
Yep, resource CL is: http://codereview.chromium.org/10800103/
8 years, 5 months ago (2012-07-24 18:50:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10815075/8001
8 years, 5 months ago (2012-07-25 00:24:17 UTC) #4
commit-bot: I haz the power
Presubmit check for 10815075-8001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-25 00:24:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10815075/8001
8 years, 5 months ago (2012-07-25 13:19:13 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 14:54:56 UTC) #7
Change committed as 148326

Powered by Google App Engine
This is Rietveld 408576698