Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: ppapi/shared_impl/resource.h

Issue 10815073: Refactoring of new IPC-only pepper implementation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/resource_creation_proxy.cc ('k') | ppapi/shared_impl/resource.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/resource.h
diff --git a/ppapi/shared_impl/resource.h b/ppapi/shared_impl/resource.h
index efe40daff329108adf70e824ed6b736dcfa1ea3c..05dc78361cb1294fe5bbd63db03b9c90bf144a7e 100644
--- a/ppapi/shared_impl/resource.h
+++ b/ppapi/shared_impl/resource.h
@@ -71,6 +71,12 @@ class Message;
namespace ppapi {
+// Normally we shouldn't reply on proxy here, but this is to support
+// OnReplyReceived. See that comment.
+namespace proxy {
+class ResourceMessageReplyParams;
+}
+
// Forward declare all the resource APIs.
namespace thunk {
#define DECLARE_RESOURCE_CLASS(RESOURCE) class RESOURCE;
@@ -166,10 +172,8 @@ class PPAPI_SHARED_EXPORT Resource : public base::RefCounted<Resource> {
template <typename T> T* GetAs() { return NULL; }
// Called when a PpapiPluginMsg_ResourceReply reply is received for a
- // previous CallRenderer. The sequence number is the value returned the
- // send function for the given request. The message is the nested reply
- // message, which may be an empty message (depending on what the host
- // sends).
+ // previous CallRenderer. The message is the nested reply message, which may
+ // be an empty message (depending on what the host sends).
//
// The default implementation will assert (if you send a request, you should
// override this function).
@@ -177,8 +181,7 @@ class PPAPI_SHARED_EXPORT Resource : public base::RefCounted<Resource> {
// (This function would make more conceptual sense on PluginResource but we
// need to call this function from general code that doesn't know how to
// distinguish the classes.)
- virtual void OnReplyReceived(int sequence,
- int32_t result,
+ virtual void OnReplyReceived(const proxy::ResourceMessageReplyParams& params,
const IPC::Message& msg);
protected:
« no previous file with comments | « ppapi/proxy/resource_creation_proxy.cc ('k') | ppapi/shared_impl/resource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698