Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1799)

Unified Diff: content/renderer/pepper/pepper_file_chooser_host_browsertest.cc

Issue 10815073: Refactoring of new IPC-only pepper implementation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/pepper_file_chooser_host_browsertest.cc
diff --git a/content/renderer/pepper/pepper_file_chooser_host_browsertest.cc b/content/renderer/pepper/pepper_file_chooser_host_browsertest.cc
index 6a482d34c5d5bcb56b152468732e5488270a00f3..dabf48d25b44cae7033314ae2275b9e120c68539 100644
--- a/content/renderer/pepper/pepper_file_chooser_host_browsertest.cc
+++ b/content/renderer/pepper/pepper_file_chooser_host_browsertest.cc
@@ -63,36 +63,13 @@ std::string FilePathToUTF8(const FilePath::StringType& path) {
#endif
}
-class MockInstanceState : public PepperInstanceStateAccessor {
- public:
- MockInstanceState() : has_user_gesture_(true) {}
- virtual ~MockInstanceState() {}
-
- void set_has_user_gesture(bool has) { has_user_gesture_ = has; }
-
- // PepperInstanceStateAccessor.
- virtual bool IsValidInstance(PP_Instance instance) OVERRIDE {
- return true;
- }
- virtual bool HasUserGesture(PP_Instance instance) OVERRIDE {
- return has_user_gesture_;
- }
-
- private:
- bool has_user_gesture_;
-};
-
} // namespace
TEST_F(PepperFileChooserHostTest, Show) {
PP_Resource pp_resource = 123;
- MockInstanceState state;
- ppapi::proxy::ResourceMessageTestSink sink;
- ppapi::host::PpapiHost host(&sink, NULL, ppapi::PpapiPermissions());
- RenderViewImpl* view_impl = static_cast<RenderViewImpl*>(view_);
- PepperFileChooserHost chooser(&host, pp_instance(), pp_resource, view_impl,
- &state);
+ MockRendererPpapiHost host(view_, pp_instance());
+ PepperFileChooserHost chooser(&host, pp_instance(), pp_resource);
std::vector<std::string> accept;
accept.push_back("text/plain");
@@ -131,7 +108,7 @@ TEST_F(PepperFileChooserHostTest, Show) {
// This should have sent the Pepper reply to our test sink.
ppapi::proxy::ResourceMessageReplyParams reply_params;
IPC::Message reply_msg;
- ASSERT_TRUE(sink.GetFirstResourceReplyMatching(
+ ASSERT_TRUE(host.sink().GetFirstResourceReplyMatching(
PpapiPluginMsg_FileChooser_ShowReply::ID, &reply_params, &reply_msg));
// Basic validation of reply.
@@ -152,15 +129,11 @@ TEST_F(PepperFileChooserHostTest, Show) {
TEST_F(PepperFileChooserHostTest, NoUserGesture) {
PP_Resource pp_resource = 123;
- MockInstanceState state;
- ppapi::proxy::ResourceMessageTestSink sink;
- ppapi::host::PpapiHost host(&sink, NULL, ppapi::PpapiPermissions());
- RenderViewImpl* view_impl = static_cast<RenderViewImpl*>(view_);
- PepperFileChooserHost chooser(&host, pp_instance(), pp_resource, view_impl,
- &state);
+ MockRendererPpapiHost host(view_, pp_instance());
+ PepperFileChooserHost chooser(&host, pp_instance(), pp_resource);
// Say there's no user gesture.
- state.set_has_user_gesture(false);
+ host.set_has_user_gesture(false);
std::vector<std::string> accept;
accept.push_back("text/plain");

Powered by Google App Engine
This is Rietveld 408576698