Issue 10815069: Add CSS variables feature flag to chrome://flags.

Issue 10815069: Add CSS variables feature flag to chrome://flags. (Closed)

Created:
8 years, 5 months ago by macpherson

Modified:
8 years, 5 months ago

Reviewers:
darin (slow to review), jam, Roland Steiner

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dglazkov

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add CSS variables feature flag to chrome://flags. This adds the ability to change the value of the WebKit runtime flag added in http://trac.webkit.org/changeset/121229 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148286

Patch Set 2 : Fix roland's feedback. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/common/view_messages.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Roland Steiner

http://chromiumcodereview.appspot.com/10815069/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): http://chromiumcodereview.appspot.com/10815069/diff/1/content/public/common/content_switches.cc#newcode251 content/public/common/content_switches.cc:251: // Enables CSS3 variables CSS3 (?) http://chromiumcodereview.appspot.com/10815069/diff/1/webkit/glue/webpreferences.cc File webkit/glue/webpreferences.cc ...

8 years, 5 months ago (2012-07-24 05:58:55 UTC) #2

Roland Steiner

LGTM in principle, although I'm not really up-to-date with the codebase to know all the ...

8 years, 5 months ago (2012-07-24 07:55:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/macpherson@chromium.org/10815069/5001

8 years, 5 months ago (2012-07-24 23:25:00 UTC) #6

commit-bot: I haz the power

Try job failure for 10815069-5001 (retry) on mac_rel for step "browser_tests". It's a second try, ...

8 years, 5 months ago (2012-07-25 00:36:57 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/macpherson@chromium.org/10815069/5001

8 years, 5 months ago (2012-07-25 01:10:50 UTC) #8

Change committed as 148286

Expand Messages | Collapse Messages