Issue 10815061: Valgrind/Heapchecker: Add content_browsertests to chrome_tests.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10815061: Valgrind/Heapchecker: Add content_browsertests to chrome_tests.py (Closed)

Created:
8 years, 5 months ago by Lei Zhang

Modified:
8 years, 5 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Valgrind/Heapchecker: Add content_browsertets to chrome_tests.py BUG=none TEST=none TBR=timurrrr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148200

Patch Set 1 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -26 lines)			Patch
	M	tools/heapcheck/chrome_tests.py	View		4 chunks	+24 lines, -20 lines	0 comments	Download
	M	tools/valgrind/chrome_tests.py	View		3 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

8 years, 5 months ago (2012-07-25 07:42:17 UTC) #3

LGTM.
Sorry for the delay - was a bit overloaded with patches and meetings
yesterday...

feel free to TBR in general;
also, splitting "reorder" and "add content_browsertests" into two patches would
be slightly easier to review (e.g. from an Android phone :P)

Expand Messages | Collapse Messages