Issue 10815060: Relanding this as the initial attempt was reverted because of linux chrome os compile failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10815060: Relanding this as the initial attempt was reverted because of linux chrome os compile failures. (Closed)

Created:
8 years, 5 months ago by ananta

Modified:
8 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Relanding this as the initial attempt was reverted because of linux chrome os compile failures. Move the HungRendererDialogView and HungPagesTableModel classes into a header file hung_renderer_view.h. Add a windows specific override of the HungRendererDialogView class. This is in preparation for displaying the hung renderer dialog using the native metro dialog UI in Windows 8 metro. BUG=125672 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147919

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -628 lines)			Patch
A +	chrome/browser/ui/views/hung_renderer_view.h	View	3	5 chunks	+29 lines, -456 lines	0 comments	Download
M	chrome/browser/ui/views/hung_renderer_view.cc	View		10 chunks	+41 lines, -172 lines	0 comments	Download
A	chrome/browser/ui/views/hung_renderer_view_win.h	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/hung_renderer_view_win.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages