gdata: Check entry_proto.get() before calling has_file_specific_info()

gdata: Check entry_proto.get() before calling has_file_specific_info()

entry_proto can be NULL if there was an error in GetEntryInfoByPath()
hence we should check entry_proto.get() beforehand.

BUG=137882
TEST=out/Release/unit_tests --gtest_filter=GData*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147917

[achuithb, 2012-07-23 18:52:23]

http://codereview.chromium.org/10815058/diff/1/chrome/browser/chromeos/extens...
File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right):

http://codereview.chromium.org/10815058/diff/1/chrome/browser/chromeos/extens...
chrome/browser/chromeos/extensions/file_browser_private_api.cc:1820: if
(entry_proto.get() && !entry_proto->has_file_specific_info())
Is this logic correct?

Shouldn't it be:
if (!entry_proto.get() || !entry_proto->has_file_specific_info())

Same everywhere.

[satorux1, 2012-07-23 19:25:34]

http://codereview.chromium.org/10815058/diff/1/chrome/browser/chromeos/extens...
File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right):

http://codereview.chromium.org/10815058/diff/1/chrome/browser/chromeos/extens...
chrome/browser/chromeos/extensions/file_browser_private_api.cc:1820: if
(entry_proto.get() && !entry_proto->has_file_specific_info())
On 2012/07/23 18:52:23, achuith.bhandarkar wrote:
> Is this logic correct?
> 
> Shouldn't it be:
> if (!entry_proto.get() || !entry_proto->has_file_specific_info())
> 
> Same everywhere.

this logic is correct. if entry_proto.get() is null, |error| should be set
properly to something other than OK

[achuithb, 2012-07-23 19:43:21]

lgtm