Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 10815057: Fix top crasher. (Closed)

Created:
8 years, 5 months ago by Elliot Glaysher
Modified:
8 years, 4 months ago
Reviewers:
sky, dharani
CC:
chromium-reviews
Visibility:
Public.

Description

Fix top crasher. Message loop captured in constructor is not the UI loop. Get a UI message loop proxy in the ExecuteParams constructor and use that instead. BUG=138087 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147976

Patch Set 1 #

Patch Set 2 : Compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M ui/base/dialogs/select_file_dialog_win.cc View 1 5 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
So, I thought I didn't change the threading here because the linux code stores a ...
8 years, 5 months ago (2012-07-23 20:22:01 UTC) #1
sky
LGTM
8 years, 5 months ago (2012-07-23 20:59:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10815057/3
8 years, 5 months ago (2012-07-23 21:00:31 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-23 22:48:56 UTC) #4
Change committed as 147976

Powered by Google App Engine
This is Rietveld 408576698