Issue 10815051: Send the correct process ID with webNavigation events

Issue 10815051: Send the correct process ID with webNavigation events (Closed)

Created:
8 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 5 months ago

Reviewers:
battre

CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, gavinp+prer_chromium.org, tburkard+watch_chromium.org, Aaron Boodman, dominich+watch_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Send the correct process ID with webNavigation events BUG=136090 TEST=browser_tests:*WebNavigation* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147847

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+183 lines, -24 lines)			Patch
M	chrome/browser/extensions/api/web_navigation/web_navigation_api.cc	View	6 chunks	+8 lines, -16 lines	0 comments	Download
M	chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc	View	4 chunks	+4 lines, -4 lines	2 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/framework.js	View	3 chunks	+12 lines, -4 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_clientRedirect.js	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_failures.js	View	12 chunks	+22 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_forwardBack.js	View	4 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_history.js	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_iframe.js	View	13 chunks	+40 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_openTab.js	View	9 chunks	+22 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_prerender.js	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_referenceFragment.js	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_requestOpenTab.js	View	4 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_serverRedirect.js	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_simpleLoad.js	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_targetBlank.js	View	4 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_userAction.js	View	4 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

battre

lgtm https://chromiumcodereview.appspot.com/10815051/diff/1/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc File chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc (right): https://chromiumcodereview.appspot.com/10815051/diff/1/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc#newcode84 chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc:84: content::WebContents* web_contents, Optional: have you considered passing the ...

8 years, 5 months ago (2012-07-23 12:06:35 UTC) #2

jochen (gone - plz use gerrit)

8 years, 5 months ago (2012-07-23 13:17:12 UTC) #3

https://chromiumcodereview.appspot.com/10815051/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc
(right):

https://chromiumcodereview.appspot.com/10815051/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc:84:
content::WebContents* web_contents,
On 2012/07/23 12:06:35, battre wrote:
> Optional: have you considered passing the render_process_id in all dispatch
> methods for consistency?

Yes, but I didn't like it :)

The places I pass the process_id are when it's different from the one in
web_contents->GetRenderViewHost()->GetProcess()->GetID().

Expand Messages | Collapse Messages