Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1835)

Unified Diff: ui/gl/gl_surface_egl.cc

Issue 10815041: Make NativeViewGLSurfaceEGL directly usable on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use angle EGL headers on Android too Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/native_widget_types.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_surface_egl.cc
diff --git a/ui/gl/gl_surface_egl.cc b/ui/gl/gl_surface_egl.cc
index 3fda8e7b97f7220257b7808af2064e80b34a0e53..a1214cf488bc17e7d1877e5a5d74e06b35615244 100644
--- a/ui/gl/gl_surface_egl.cc
+++ b/ui/gl/gl_surface_egl.cc
@@ -8,17 +8,11 @@
#include "base/memory/scoped_ptr.h"
#include "base/message_loop.h"
#include "build/build_config.h"
-#if !defined(OS_ANDROID)
#include "third_party/angle/include/EGL/egl.h"
#include "third_party/angle/include/EGL/eglext.h"
-#endif
#include "ui/gl/egl_util.h"
#include "ui/gl/gl_context.h"
-#if defined(OS_ANDROID)
-#include <EGL/egl.h>
-#endif
-
// This header must come after the above third-party include, as
// it brings in #defines that cause conflicts.
#include "ui/gl/gl_bindings.h"
@@ -172,10 +166,6 @@ NativeViewGLSurfaceEGL::NativeViewGLSurfaceEGL(bool software,
}
bool NativeViewGLSurfaceEGL::Initialize() {
-#if defined(OS_ANDROID)
- NOTREACHED();
- return false;
-#else
DCHECK(!surface_);
if (!GetDisplay()) {
@@ -211,7 +201,6 @@ bool NativeViewGLSurfaceEGL::Initialize() {
supports_post_sub_buffer_ = (surfaceVal && retVal) == EGL_TRUE;
return true;
-#endif
}
void NativeViewGLSurfaceEGL::Destroy() {
« no previous file with comments | « ui/gfx/native_widget_types.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698