Make NativeViewGLSurfaceEGL directly usable on Android.

Make NativeViewGLSurfaceEGL directly usable on Android.

Define AcceleratedWidget as ANativeWindow* which can be
used to create an EGLSurface.
Also do allow direct initialization of NativeViewGLSurfaceEGL.

BUG=136923
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147879

[no sievers, 2012-07-20 20:31:59]

https://chromiumcodereview.appspot.com/10815041/diff/1/ui/gl/gl_surface_egl.cc
File ui/gl/gl_surface_egl.cc (right):

https://chromiumcodereview.appspot.com/10815041/diff/1/ui/gl/gl_surface_egl.c...
ui/gl/gl_surface_egl.cc:183: #if defined(EGL_NV_post_sub_buffer)
Is this good?
This is not defined in the Android SDK header.

[piman, 2012-07-20 20:44:08]

https://chromiumcodereview.appspot.com/10815041/diff/1/ui/gl/gl_surface_egl.cc
File ui/gl/gl_surface_egl.cc (right):

https://chromiumcodereview.appspot.com/10815041/diff/1/ui/gl/gl_surface_egl.c...
ui/gl/gl_surface_egl.cc:183: #if defined(EGL_NV_post_sub_buffer)
On 2012/07/20 20:31:59, Daniel Sievers wrote:
> Is this good?
> This is not defined in the Android SDK header.

bleh... we have 3 sets of includes: the ones in third_party/angle, the ones in
third_party/khronos, and the system ones...
Do you know the reason why we use the system ones on Android? Could we try to
use either the angle ones or the khronos ones instead (both seem to have
EGL_POST_SUB_BUFFER_SUPPORTED_NV) - possibly fixing them as needed?

[no sievers, 2012-07-20 21:11:05]

http://codereview.chromium.org/10815041/diff/1/ui/gl/gl_surface_egl.cc
File ui/gl/gl_surface_egl.cc (right):

http://codereview.chromium.org/10815041/diff/1/ui/gl/gl_surface_egl.cc#newcod...
ui/gl/gl_surface_egl.cc:183: #if defined(EGL_NV_post_sub_buffer)
Word. Especially, since this file is explicit about using the angle header.

On 2012/07/20 20:44:08, piman wrote:
> On 2012/07/20 20:31:59, Daniel Sievers wrote:
> > Is this good?
> > This is not defined in the Android SDK header.
> 
> bleh... we have 3 sets of includes: the ones in third_party/angle, the ones in
> third_party/khronos, and the system ones...
> Do you know the reason why we use the system ones on Android? Could we try to
> use either the angle ones or the khronos ones instead (both seem to have
> EGL_POST_SUB_BUFFER_SUPPORTED_NV) - possibly fixing them as needed?

[piman, 2012-07-20 21:19:19]

*much* nicer ;)
LGTM

[apatrick_chromium, 2012-07-20 21:35:39]

lgtm

[no sievers, 2012-07-20 23:55:46]

need OWNERS lgtm from sky for native_widget_types.h

[sky, 2012-07-21 00:04:13]

LGTM

[commit-bot: I haz the power, 2012-07-23 16:21:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/10815041/1003

[commit-bot: I haz the power, 2012-07-23 17:41:02]

Change committed as 147879