Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 10815035: Merge 122769 - Inconsistent rounding in table layout causes background color to bleed through (Closed)

Created:
8 years, 5 months ago by eae
Modified:
8 years, 5 months ago
Reviewers:
eae
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/
Visibility:
Public.

Description

Merge 122769 - Inconsistent rounding in table layout causes background color to bleed through https://bugs.webkit.org/show_bug.cgi?id=91410 Reviewed by Eric Seidel. Source/WebCore: At certain zoom levels a rounding error in the table layout code cases the table background color to bleed through between cells. Tables layout happens on pixel bounds however the paint offset wasn't correctly rounded. Test: fast/sub-pixel/table-rows-no-gaps.html * rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject): Round paintOffset before passing it to the paint method of the children. LayoutTests: Add test to ensure that the table background color doesn't bleed through when the table and a cell are positioned on a subpixel bound. * fast/sub-pixel/table-rows-no-gaps-expected.html: Added. * fast/sub-pixel/table-rows-no-gaps.html: Added. * platform/chromium-linux/css1/basic/inheritance-expected.png: * platform/chromium-linux/plugins/embed-attributes-style-expected.png: * platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: * platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: * platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png: Updated expectations to match new rounding logic. The new results better match the rendering prior to turning on subpixel layout. * platform/efl/Skipped: * platform/mac-lion/Skipped: * platform/mac-snowleopard/Skipped: * platform/mac-wk2/Skipped: * platform/mac/Skipped: * platform/qt-4.8/Skipped: * platform/qt/Skipped: * platform/win-wk2/Skipped: * platform/win-xp/Skipped: * platform/win/Skipped: * platform/wincairo/Skipped: * platform/wk2/Skipped: Mark new test as skipped on platforms that have not enabled subpixel layout. TBR=eae@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -23 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +38 lines, -0 lines 0 comments Download
A + LayoutTests/fast/sub-pixel/table-rows-no-gaps.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/sub-pixel/table-rows-no-gaps-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/chromium-linux/css1/basic/inheritance-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-linux/plugins/embed-attributes-style-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png View Binary file 0 comments Download
M LayoutTests/platform/efl/Skipped View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac-lion/Skipped View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac-snowleopard/Skipped View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac-wk2/Skipped View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/Skipped View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/platform/qt-4.8/Skipped View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/platform/qt/Skipped View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-wk2/Skipped View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/Skipped View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/Skipped View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/platform/wincairo/Skipped View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/platform/wk2/Skipped View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderTable.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
eae
8 years, 5 months ago (2012-07-20 17:49:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698