Issue 10815034: Merged r11533 into 3.8 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10815034: Merged r11533 into 3.8 branch. (Closed)

Created:
8 years, 5 months ago by danno

Modified:
8 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.8

Visibility:
Public.

More Reviews

Description

Merged r11533 into 3.8 branch. Properly set ElementsKind of empty FAST_DOUBLE_ELEMENTS arrays when transitioning. R=mstarzinger@chromium.org BUG=chromium:117409 Committed: https://code.google.com/p/v8/source/detail?r=12163

Patch Set 2 : Patch isn't relevant to 3.8, just merge unit test #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -32 lines)			Patch
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-117409.js	View		1 chunk	+18 lines, -31 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

https://chromiumcodereview.appspot.com/10815034/diff/1/src/builtins.cc File src/builtins.cc (right): https://chromiumcodereview.appspot.com/10815034/diff/1/src/builtins.cc#newcode448 src/builtins.cc:448: if (array->HasFastDoubleElements()) { As discussed offline: This fix might ...

8 years, 5 months ago (2012-07-20 13:39:40 UTC) #2

LGTM (if regression test succeeds).

Expand Messages | Collapse Messages

Issue 10815034: Merged r11533 into 3.8 branch. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Patch isn't relevant to 3.8, just merge unit test #

Messages