Make ActiveTabPermissionManager also grant the tabs permission.

chrome/common/extensions/extension_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include "base/format_macros.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/path_service.h"
 #include "base/stringprintf.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/command.h"
 #include "chrome/common/extensions/extension_action.h"
 #include "chrome/common/extensions/extension_error_utils.h"
 #include "chrome/common/extensions/extension_file_util.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/extensions/extension_resource.h"
+#include "chrome/common/extensions/permissions/permission_set.h"
+#include "chrome/common/extensions/permissions/api_permission.h"
 #include "chrome/common/url_constants.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/mime_sniffer.h"
 #include "skia/ext/image_operations.h"
 #include "net/base/mock_host_resolver.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/codec/png_codec.h"
 
 using extensions::Extension;
+using extensions::PermissionSet;
+using extensions::APIPermissionSet;
 
 namespace keys = extension_manifest_keys;
 namespace values = extension_manifest_values;
 namespace errors = extension_manifest_errors;
 
 namespace {
 
 void CompareLists(const std::vector<std::string>& expected,
                   const std::vector<std::string>& actual) {
   ASSERT_EQ(expected.size(), actual.size());
@@ skipping 821 matching lines @@
   EXPECT_TRUE(Blocked(extension, favicon_url));
   EXPECT_TRUE(Blocked(extension, about_url));
   EXPECT_TRUE(Blocked(extension, extension_url));
   EXPECT_FALSE(extension->HasHostPermission(settings_url));
 }
 
 TEST_F(ExtensionScriptAndCaptureVisibleTest, TabSpecific) {
   scoped_refptr<Extension> extension =
       LoadManifestStrict("script_and_capture", "tab_specific.json");
 
-  EXPECT_EQ(NULL, extension->GetTabSpecificHostPermissions(0));
-  EXPECT_EQ(NULL, extension->GetTabSpecificHostPermissions(1));
-  EXPECT_EQ(NULL, extension->GetTabSpecificHostPermissions(2));
+  EXPECT_FALSE(extension->GetTabSpecificPermissions(0).get());

[not at google - send to devlin, 2012/07/25 07:03:46]

I just did enough throughout here to make the tests pass, so that I can run a
tryjob and head home for the day, happy.

I need to test the Update stuff properly, and the new HasAPIPermissionForTab
test, and possibly more. We shall see.

But this patch is big enough such that I think it can do with a round of
reviews.

+  EXPECT_FALSE(extension->GetTabSpecificPermissions(1).get());
+  EXPECT_FALSE(extension->GetTabSpecificPermissions(2).get());
 
   std::set<GURL> no_urls;
 
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 0));
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 1));
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 2));
 
   URLPatternSet allowed_hosts;
-    allowed_hosts.AddPattern(URLPattern(URLPattern::SCHEME_ALL,
-                                        http_url.spec()));
+  allowed_hosts.AddPattern(URLPattern(URLPattern::SCHEME_ALL,
+                                      http_url.spec()));
   std::set<GURL> allowed_urls;
-    allowed_urls.insert(http_url);
-    // http_url_with_path() will also be allowed, because Extension should be
-    // considering the security origin of the URL not the URL itself, and
-    // http_url is in allowed_hosts.
-    allowed_urls.insert(http_url_with_path);
+  allowed_urls.insert(http_url);
+  // http_url_with_path() will also be allowed, because Extension should be
+  // considering the security origin of the URL not the URL itself, and
+  // http_url is in allowed_hosts.
+  allowed_urls.insert(http_url_with_path);
 
-  extension->SetTabSpecificHostPermissions(0, allowed_hosts);
-  EXPECT_EQ(allowed_hosts, *extension->GetTabSpecificHostPermissions(0));
+  {
+    scoped_refptr<PermissionSet> permissions(
+        new PermissionSet(APIPermissionSet(), allowed_hosts, URLPatternSet()));
+    extension->UpdateTabSpecificPermissions(0, permissions);
+    EXPECT_EQ(permissions->explicit_hosts(),
+              extension->GetTabSpecificPermissions(0)->explicit_hosts());
+  }
 
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, allowed_urls, 0));
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 1));
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 2));
 
-  extension->ClearTabSpecificHostPermissions(0);
-  EXPECT_EQ(NULL, extension->GetTabSpecificHostPermissions(0));
+  extension->ClearTabSpecificPermissions(0);
+  EXPECT_FALSE(extension->GetTabSpecificPermissions(0).get());
 
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 0));
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 1));
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 2));
 
   std::set<GURL> more_allowed_urls = allowed_urls;
-    more_allowed_urls.insert(https_url);
+  more_allowed_urls.insert(https_url);
   URLPatternSet more_allowed_hosts = allowed_hosts;
-    more_allowed_hosts.AddPattern(URLPattern(URLPattern::SCHEME_ALL,
-                                             https_url.spec()));
+  more_allowed_hosts.AddPattern(URLPattern(URLPattern::SCHEME_ALL,
+                                           https_url.spec()));
 
-  extension->SetTabSpecificHostPermissions(0, allowed_hosts);
-  EXPECT_EQ(allowed_hosts, *extension->GetTabSpecificHostPermissions(0));
-  extension->SetTabSpecificHostPermissions(1, more_allowed_hosts);
-  EXPECT_EQ(more_allowed_hosts, *extension->GetTabSpecificHostPermissions(1));
+  {
+    scoped_refptr<PermissionSet> permissions(
+        new PermissionSet(APIPermissionSet(), allowed_hosts, URLPatternSet()));
+    extension->UpdateTabSpecificPermissions(0, permissions);
+    EXPECT_EQ(permissions->explicit_hosts(),
+              extension->GetTabSpecificPermissions(0)->explicit_hosts());
+
+    permissions = new PermissionSet(APIPermissionSet(),
+                                    more_allowed_hosts,
+                                    URLPatternSet());
+    extension->UpdateTabSpecificPermissions(1, permissions);
+    EXPECT_EQ(permissions->explicit_hosts(),
+              extension->GetTabSpecificPermissions(1)->explicit_hosts());
+  }
 
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, allowed_urls, 0));
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, more_allowed_urls, 1));
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 2));
 
-  extension->ClearTabSpecificHostPermissions(0);
-  EXPECT_EQ(NULL, extension->GetTabSpecificHostPermissions(0));
+  extension->ClearTabSpecificPermissions(0);
+  EXPECT_FALSE(extension->GetTabSpecificPermissions(0).get());
 
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 0));
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, more_allowed_urls, 1));
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 2));
 
-  extension->ClearTabSpecificHostPermissions(1);
-  EXPECT_EQ(NULL, extension->GetTabSpecificHostPermissions(1));
+  extension->ClearTabSpecificPermissions(1);
+  EXPECT_FALSE(extension->GetTabSpecificPermissions(1).get());
 
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 0));
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 1));
   EXPECT_TRUE(AllowedExclusivelyOnTab(extension, no_urls, 2));
 }
 
 TEST(ExtensionTest, GenerateId) {
   std::string result;
   EXPECT_TRUE(Extension::GenerateId("", &result));
 
@@ skipping 151 matching lines @@
 }
 
 TEST(ExtensionTest, GetSyncTypeExtensionWithTwoPlugins) {
   scoped_refptr<Extension> extension(
       MakeSyncTestExtension(EXTENSION, GURL(), GURL(),
                             Extension::INTERNAL, 2, FilePath()));
   if (extension)
     EXPECT_EQ(extension->GetSyncType(), Extension::SYNC_TYPE_NONE);
 }
 #endif // !defined(OS_CHROMEOS)