Make ActiveTabPermissionManager also grant the tabs permission.

chrome/browser/extensions/extension_function.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_H_
 
 #include <list>
 #include <string>
 
@@ skipping 26 matching lines @@
 }
 
 namespace content {
 class RenderViewHost;
 }
 
 namespace extensions {
 class WindowController;
 }
 
+#ifdef NDEBUG

[not at google - send to devlin, 2012/07/25 07:03:46]

Pretty please I want to make this change. It's really annoying when chrome
crashes when it tries to send the response in debug mode, rather than crashing
at the moment it should have failed.

 #define EXTENSION_FUNCTION_VALIDATE(test) do { \
     if (!(test)) { \
       bad_message_ = true; \
       return false; \
     } \
   } while (0)
+#else   // NDEBUG
+#define EXTENSION_FUNCTION_VALIDATE(test) CHECK(test)
+#endif  // NDEBUG
 
 #define EXTENSION_FUNCTION_ERROR(error) do { \
     error_ = error; \
     bad_message_ = true; \
     return false; \
   } while (0)
 
 #define DECLARE_EXTENSION_FUNCTION_NAME(name) \
   public: static const char* function_name() { return name; }
 
 // Traits that describe how ExtensionFunction should be deleted. This just calls
 // the virtual "Destruct" method on ExtensionFunction, allowing derived classes
 // to override the behavior.
 struct ExtensionFunctionDeleteTraits {
  public:
   static void Destruct(const ExtensionFunction* x);
 };
 
 // Abstract base class for extension functions the ExtensionFunctionDispatcher
 // knows how to dispatch to.
 class ExtensionFunction
     : public base::RefCountedThreadSafe<ExtensionFunction,
                                         ExtensionFunctionDeleteTraits> {
  public:
   ExtensionFunction();
 
   virtual UIThreadExtensionFunction* AsUIThreadExtensionFunction();
   virtual IOThreadExtensionFunction* AsIOThreadExtensionFunction();
 
+  // Returns true if the function permission to run.
+  //
+  // The default implementation is to check the Extension's permissions against
+  // what this function requires to run, but some APIs may require finer
+  // grained control, such as tabs.executeScript being allowed for active tabs.
+  //
+  // This will be run after the function has been set up but before Run().
+  virtual bool HasPermission();
+
   // Execute the API. Clients should initialize the ExtensionFunction using
   // SetArgs(), set_request_id(), and the other setters before calling this
   // method. Derived classes should be ready to return GetResultList() and
   // GetError() before returning from this function.
   // Note that once Run() returns, dispatcher() can be NULL, so be sure to
   // NULL-check.
   virtual void Run();
 
   // Gets whether quota should be applied to this individual function
   // invocation. This is different to GetQuotaLimitHeuristics which is only
@@ skipping 338 matching lines @@
  public:
   SyncIOThreadExtensionFunction();
 
   virtual void Run() OVERRIDE;
 
  protected:
   virtual ~SyncIOThreadExtensionFunction();
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_FUNCTION_H_