Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: chrome/browser/extensions/active_tab_permission_manager.cc

Issue 10815028: Make ActiveTabPermissionManager also grant the tabs permission. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: oops Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/active_tab_permission_manager.h" 5 #include "chrome/browser/extensions/active_tab_permission_manager.h"
6 6
7 #include "chrome/browser/extensions/extension_service.h" 7 #include "chrome/browser/extensions/extension_service.h"
8 #include "chrome/browser/extensions/extension_system.h" 8 #include "chrome/browser/extensions/extension_system.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/sessions/session_id.h" 10 #include "chrome/browser/sessions/session_id.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 if (IsGranted(extension)) 42 if (IsGranted(extension))
43 return; 43 return;
44 44
45 URLPattern pattern(UserScript::kValidUserScriptSchemes); 45 URLPattern pattern(UserScript::kValidUserScriptSchemes);
46 if (pattern.Parse(web_contents()->GetURL().spec()) != 46 if (pattern.Parse(web_contents()->GetURL().spec()) !=
47 URLPattern::PARSE_SUCCESS) { 47 URLPattern::PARSE_SUCCESS) {
48 // Pattern parsing could fail if this is an unsupported URL e.g. chrome://. 48 // Pattern parsing could fail if this is an unsupported URL e.g. chrome://.
49 return; 49 return;
50 } 50 }
51 51
52 URLPatternSet new_permissions; 52 APIPermissionSet new_apis;
53 const URLPatternSet* old_permissions = 53 new_apis.insert(APIPermission::kTab);
54 extension->GetTabSpecificHostPermissions(tab_id_); 54 URLPatternSet new_hosts;
55 if (old_permissions) 55 new_hosts.AddPattern(pattern);
56 new_permissions.AddPatterns(*old_permissions);
57 56
58 new_permissions.AddPattern(pattern); 57 extension->UpdateTabSpecificPermissions(
58 tab_id_, new PermissionSet(new_apis, new_hosts, URLPatternSet()));
59 granted_extensions_.Insert(extension); 59 granted_extensions_.Insert(extension);
60 extension->SetTabSpecificHostPermissions(tab_id_, new_permissions);
61 Send(new ExtensionMsg_UpdateTabSpecificPermissions(GetPageID(), 60 Send(new ExtensionMsg_UpdateTabSpecificPermissions(GetPageID(),
62 tab_id_, 61 tab_id_,
63 extension->id(), 62 extension->id(),
64 new_permissions)); 63 new_hosts));
65 } 64 }
66 65
67 bool ActiveTabPermissionManager::IsGranted(const Extension* extension) { 66 bool ActiveTabPermissionManager::IsGranted(const Extension* extension) {
68 return granted_extensions_.Contains(extension->id()); 67 return granted_extensions_.Contains(extension->id());
69 } 68 }
70 69
71 void ActiveTabPermissionManager::DidNavigateMainFrame( 70 void ActiveTabPermissionManager::DidNavigateMainFrame(
72 const content::LoadCommittedDetails& details, 71 const content::LoadCommittedDetails& details,
73 const content::FrameNavigateParams& params) { 72 const content::FrameNavigateParams& params) {
74 if (details.is_in_page) 73 if (details.is_in_page)
(...skipping 20 matching lines...) Expand all
95 } 94 }
96 95
97 void ActiveTabPermissionManager::ClearActiveExtensionsAndNotify() { 96 void ActiveTabPermissionManager::ClearActiveExtensionsAndNotify() {
98 if (granted_extensions_.is_empty()) 97 if (granted_extensions_.is_empty())
99 return; 98 return;
100 99
101 std::vector<std::string> extension_ids; 100 std::vector<std::string> extension_ids;
102 101
103 for (ExtensionSet::const_iterator it = granted_extensions_.begin(); 102 for (ExtensionSet::const_iterator it = granted_extensions_.begin();
104 it != granted_extensions_.end(); ++it) { 103 it != granted_extensions_.end(); ++it) {
105 (*it)->ClearTabSpecificHostPermissions(tab_id_); 104 (*it)->ClearTabSpecificPermissions(tab_id_);
106 extension_ids.push_back((*it)->id()); 105 extension_ids.push_back((*it)->id());
107 } 106 }
108 107
109 Send(new ExtensionMsg_ClearTabSpecificPermissions(tab_id_, extension_ids)); 108 Send(new ExtensionMsg_ClearTabSpecificPermissions(tab_id_, extension_ids));
110 granted_extensions_.Clear(); 109 granted_extensions_.Clear();
111 } 110 }
112 111
113 int32 ActiveTabPermissionManager::GetPageID() { 112 int32 ActiveTabPermissionManager::GetPageID() {
114 return web_contents()->GetController().GetActiveEntry()->GetPageID(); 113 return web_contents()->GetController().GetActiveEntry()->GetPageID();
115 } 114 }
116 115
117 } // namespace extensions 116 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/active_tab_apitest.cc ('k') | chrome/browser/extensions/active_tab_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698