Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 10815027: Fix GPUTestConfigTest.LoadCurrentConfig on Android (Closed)

Created:
8 years, 5 months ago by yongsheng
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Fix GPUTestConfigTest.LoadCurrentConfig on Android It's a case in content unittests. Implement the config for Android. BUG= TEST=run_tests.py -s content_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/android/gtest_filter/content_unittests_disabled View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/gpu/gpu_test_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/gpu/gpu_test_config.cc View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
yongsheng
This is the fix for failed case 'GPUTestConfigTest.LoadCurrentConfig' on android. Next, will fix parser for ...
8 years, 5 months ago (2012-07-20 05:54:45 UTC) #1
Ken Russell (switch to Gerrit)
Very nice. CC'ing zmo.
8 years, 5 months ago (2012-07-21 01:00:18 UTC) #2
Zhenyao Mo
LGTM
8 years, 5 months ago (2012-07-21 01:11:06 UTC) #3
yongsheng
On 2012/07/21 01:11:06, Zhenyao Mo wrote: > LGTM thanks for you two's review.
8 years, 5 months ago (2012-07-22 04:15:02 UTC) #4
John Grabowski
Android LGTM
8 years, 5 months ago (2012-07-23 19:00:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10815027/1
8 years, 5 months ago (2012-07-24 01:10:51 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 03:38:26 UTC) #7
Change committed as 148040

Powered by Google App Engine
This is Rietveld 408576698