Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10815025: Move TitleWatcher from ui_test_utils.h to browser_test_utils.h so it can be reused by content_brows… (Closed)

Created:
8 years, 5 months ago by jam
Modified:
8 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, cbentzel+watch_chromium.org, jennb, gavinp+prer_chromium.org, tburkard+watch_chromium.org, jam, Dmitry Titov, dcheng, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, jianli, brettw-cc_chromium.org, markusheintz_, mmenke
Visibility:
Public.

Description

Move TitleWatcher from ui_test_utils.h to browser_test_utils.h so it can be reused by content_browsertests. BUG=90448 TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -152 lines) Patch
M chrome/browser/content_settings/content_settings_browsertest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/external_extension_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/history/history_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prefetch_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/referrer_policy_browsertest.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/old_panel_browsertest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/unload_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M content/browser/media_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/mouseleave_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/plugin_browsertest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/session_history_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/worker_host/test/worker_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/test/browser_test_utils.h View 2 chunks +48 lines, -0 lines 0 comments Download
M content/test/browser_test_utils.cc View 1 chunk +72 lines, -0 lines 0 comments Download
M content/test/layout_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 5 months ago (2012-07-20 03:41:30 UTC) #1
scottmg
8 years, 5 months ago (2012-07-20 14:30:50 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698