Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10815024: Revert 147594 - NaCl: Remove two uses of '#include "nacl/nacl_log.h"' (Closed)

Created:
8 years, 5 months ago by Mark Seaborn
Modified:
8 years, 5 months ago
Reviewers:
Mark Seaborn, bradn
CC:
chromium-reviews, asanka, mihaip-chromium-reviews_chromium.org, sadrul, Nirnimesh, ben+watch_chromium.org, kkania, Randy Smith (Not in Mondays), Aaron Boodman, robertshield, rdsmith+dwatch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 147594 - NaCl: Remove two uses of '#include "nacl/nacl_log.h"' "git cl dcommit" went crazy and appears to have reverted the 3 previous commits at the same time as committing my change. (This might be due to race conditions with running "git fetch" concurrently.) TBR=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147601

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -42 lines) Patch
M WATCHLISTS View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_file_helper.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_prefs.h View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_prefs.cc View 4 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_device_resource.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/screenshot_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/tests/ppapi_browser/ppb_audio/ppapi_ppb_audio.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ppapi/native_client/tests/ppapi_example_audio/audio.cc View 2 chunks +2 lines, -1 line 0 comments Download
M tools/json_schema_compiler/cc_generator.py View 2 chunks +18 lines, -8 lines 0 comments Download
M tools/json_schema_compiler/cpp_type_generator.py View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
8 years, 5 months ago (2012-07-20 02:04:35 UTC) #1
bradn
8 years, 5 months ago (2012-07-20 17:54:14 UTC) #2 
LGTM rubberstamp

Powered by Google App Engine
This is Rietveld 408576698