trychange.py - Issue 10815009: gclient_utils.FileWrite() assumes text data but trychange doesn't.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trychange.py

Issue 10815009: gclient_utils.FileWrite() assumes text data but trychange doesn't. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: trychange.py

diff --git a/trychange.py b/trychange.py

index 4a29aecd6ba1bce36171f8f46337ee277572932b..ceeeecea9b681af9a92f6988600f1050da6db10a 100755

--- a/trychange.py

+++ b/trychange.py

@@ -399,7 +399,8 @@ def _SendChangeSVN(options):

file_name = (Escape(options.user) + '.' + Escape(options.name) +

'.%s.diff' % current_time)

full_path = os.path.join(temp_dir, file_name)

- gclient_utils.FileWrite(full_path, options.diff, 'wb')

+ with open(full_path, 'wb') as f:

+ f.write(options.diff)

# Committing it will trigger a try job.

if sys.platform == "cygwin":

« no previous file with comments | « no previous file | no next file » | no next file with comments »