Issue 10810074: Updates to documentation for experimental.apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10810074: Updates to documentation for experimental.apps (Closed)

Created:
8 years, 5 months ago by asargent_no_longer_on_chrome

Modified:
8 years, 4 months ago

Reviewers:
miket_OOO

CC:
chromium-reviews, Aaron Boodman, mkearney1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Updates to documentation for experimental.apps -Put nodoc on experimental.apps.{notify,clearAllNotifications} since those aren't available in new packaged apps and we'll probably be doing some changes to them before we'd move them to supported anyway. -Remove nodoc from experimental.apps.onLaunched BUG=138754 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148848

Patch Set 1 #

Patch Set 2 : rebased #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -329 lines)			Patch
M	chrome/common/extensions/api/experimental_app.json	View		3 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/docs/apps/experimental.app.html	View		11 chunks	+47 lines, -150 lines	0 comments	Download
M	chrome/common/extensions/docs/extensions/experimental.app.html	View		11 chunks	+47 lines, -176 lines	0 comments	Download
M	chrome/common/extensions/docs/extensions/samples.html	View	1	2 chunks	+43 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/samples.json	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

-mihaip (either missed it, or was swamped with other reviews) +miket

8 years, 4 months ago (2012-07-27 21:40:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/10810074/3001

8 years, 4 months ago (2012-07-27 21:58:58 UTC) #4

commit-bot: I haz the power

8 years, 4 months ago (2012-07-27 21:59:04 UTC) #5

Failed to apply patch for chrome/common/extensions/docs/extensions/samples.html:
While running patch -p1 --forward --force;
patching file chrome/common/extensions/docs/extensions/samples.html
Hunk #1 FAILED at 252.
Hunk #2 succeeded at 3290 with fuzz 1 (offset 45 lines).
1 out of 2 hunks FAILED -- saving rejects to file
chrome/common/extensions/docs/extensions/samples.html.rej

Expand Messages | Collapse Messages