Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 10810073: [cros] Flip enable-html5-camera switch. (Closed)

Created:
8 years, 5 months ago by Ivan Korotkov
Modified:
8 years, 5 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

[cros] Flip enable-html5-camera switch. BUG=122764 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148214

Patch Set 1 #

Total comments: 8

Patch Set 2 : Indentation fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler.cc View 1 3 chunks +9 lines, -5 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ivan Korotkov
8 years, 5 months ago (2012-07-24 17:26:27 UTC) #1
Nikita (slow)
lgtm
8 years, 5 months ago (2012-07-24 17:59:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10810073/1
8 years, 5 months ago (2012-07-24 18:00:30 UTC) #3
commit-bot: I haz the power
Presubmit check for 10810073-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-24 18:00:39 UTC) #4
Ivan Korotkov
Adding James for OWNERS approval
8 years, 5 months ago (2012-07-24 18:14:24 UTC) #5
James Hawkins
LGTM with indentation nits. https://chromiumcodereview.appspot.com/10810073/diff/1/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc (right): https://chromiumcodereview.appspot.com/10810073/diff/1/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc#newcode71 chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc:71: HasSwitch(switches::kDisableHtml5Camera)) { Indentation is off ...
8 years, 5 months ago (2012-07-24 18:22:19 UTC) #6
Ivan Korotkov
https://chromiumcodereview.appspot.com/10810073/diff/1/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc (right): https://chromiumcodereview.appspot.com/10810073/diff/1/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc#newcode71 chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc:71: HasSwitch(switches::kDisableHtml5Camera)) { On 2012/07/24 18:22:19, James Hawkins wrote: > ...
8 years, 5 months ago (2012-07-24 20:11:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/10810073/6002
8 years, 5 months ago (2012-07-24 20:13:41 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 21:58:43 UTC) #9
Change committed as 148214

Powered by Google App Engine
This is Rietveld 408576698