Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 10810071: Fix Android FYI base|net_unittests (Closed)

Created:
8 years, 5 months ago by benm (inactive)
Modified:
8 years, 5 months ago
Reviewers:
Yaron, Satish
CC:
chromium-reviews
Visibility:
Public.

Description

Fix Android FYI base|net_unittests Add back missing -U __linux__ to common.gypi. Partial revert of https://chromiumcodereview.appspot.com/10808042/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148098

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
benm (inactive)
8 years, 5 months ago (2012-07-24 12:11:29 UTC) #1
Satish
lgtm
8 years, 5 months ago (2012-07-24 12:14:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/10810071/1
8 years, 5 months ago (2012-07-24 12:39:05 UTC) #3
commit-bot: I haz the power
Change committed as 148098
8 years, 5 months ago (2012-07-24 13:48:56 UTC) #4
Yaron
On 2012/07/24 13:48:56, I haz the power (commit-bot) wrote: > Change committed as 148098 sorry ...
8 years, 5 months ago (2012-07-24 14:46:47 UTC) #5
Yaron
8 years, 5 months ago (2012-07-24 18:17:52 UTC) #6
On 2012/07/24 14:46:47, Yaron wrote:
> On 2012/07/24 13:48:56, I haz the power (commit-bot) wrote:
> > Change committed as 148098
> 
> sorry for the breakage. Must be something's not upstreamed yet. I'll take a
look
> and try and re-land

Had to revert this due to other issues with cros arm. Did full revert of the
original

Powered by Google App Engine
This is Rietveld 408576698