lib/dom/scripts/systemnative.py - Issue 10810055: WebKit recently has been changed to pass context as 1st argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10810055: WebKit recently has been changed to pass context as 1st argument. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/dom/scripts/systemnative.py

diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py

index 6415fd3c417604f75ab8749d2106d5043619ce1f..aa346faf7551d34a1f2f90f0f034b5ce8a66b189 100644

--- a/lib/dom/scripts/systemnative.py

+++ b/lib/dom/scripts/systemnative.py

@@ -939,7 +939,9 @@ class NativeImplementationGenerator(systembase.BaseGenerator):

INVOCATION=invocation_template)

if 'ImplementedBy' in attributes:

- arguments.insert(0, 'receiver')

+ # FIXME: rather ugly way to solve the problem.

+ index = 1 if 'ScriptExecutionContext' == attributes.get('CallWith') else 0

+ arguments.insert(index, 'receiver')

self._cpp_impl_includes.add('"%s.h"' % attributes['ImplementedBy'])

return emitter.Format(invocation_template,

« no previous file with comments | « no previous file | no next file » | no next file with comments »