Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 10810035: Add libc6-i386 lib32gcc1 in dev_list. (Closed)

Created:
8 years, 5 months ago by haltonhuo
Modified:
8 years, 4 months ago
Reviewers:
cmp, Michael Moss, bradn
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add libc6-i386 lib32gcc1 in dev_list. Native client toolchain still need some extra 32 bit libraries belong to packages libc6-i386 and lib32gcc1. Instead of adding all 32-bit libraries, adding above two packages in common (64-bit and 32-bit) makes more sense. TEST=build on 64-bit linux BUG=138234 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148356

Patch Set 1 #

Patch Set 2 : Update my account to intel.com #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -1 line 0 comments Download
M build/install-build-deps.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
haltonhuo
8 years, 5 months ago (2012-07-20 12:30:20 UTC) #1
bradn
lgtm
8 years, 5 months ago (2012-07-20 16:57:36 UTC) #2
haltonhuo
ping, can anybody help to push this change. bradn?
8 years, 5 months ago (2012-07-24 02:25:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/halton.huo@intel.com/10810035/1
8 years, 5 months ago (2012-07-24 03:02:01 UTC) #4
commit-bot: I haz the power
Presubmit check for 10810035-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-24 03:02:06 UTC) #5
haltonhuo
On 2012/07/24 03:02:06, I haz the power (commit-bot) wrote: > Presubmit check for 10810035-1 failed ...
8 years, 5 months ago (2012-07-24 10:51:38 UTC) #6
bradn
It appears that your change is being rejected because your email address in AUTHORS is ...
8 years, 5 months ago (2012-07-24 23:25:58 UTC) #7
haltonhuo
Thanks for pointing me out, I update my account to intel.com in AUTHORS file. On ...
8 years, 5 months ago (2012-07-25 01:26:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/halton.huo@intel.com/10810035/7001
8 years, 5 months ago (2012-07-25 16:19:58 UTC) #9
commit-bot: I haz the power
Change committed as 148356
8 years, 5 months ago (2012-07-25 17:41:28 UTC) #10
Michael Moss
8 years, 4 months ago (2012-07-27 16:50:22 UTC) #11
FYI, this appears to break install-build-deps.sh on Ubuntu 12.x because these
packages no longer exist
(http://code.google.com/p/chromium/issues/detail?id=139338#c1). Can we come up
with a version that's compatible on all our supported systems?

Powered by Google App Engine
This is Rietveld 408576698