disable web audio by default on android and add switches to enable it

disable web audio by default on android and add switches to enable it


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148516

[Wei James(wistoch), 2012-07-20 06:19:34]

This patch is to make web audio disabled by default on Android and can use
--enable-webaudio switch for development purpose.

[Ken Russell (switch to Gerrit), 2012-07-20 07:56:52]

While the patch looks reasonably acceptable (if a little gross) I'd rather not
be the sole reviewer on this. CC'ing a few others.

[Raymond Toy, 2012-07-20 16:48:35]

On 2012/07/20 07:56:52, kbr wrote:
> While the patch looks reasonably acceptable (if a little gross) I'd rather not
> be the sole reviewer on this. CC'ing a few others.

I agree with Ken (patch is reasonable, but a little gross).  

Is it possible to make --disable-webaudio accept a value, defaulting to false
everywhere except Android, where it defaults to true?  Then Android could just
use --disable-webaudio=false to enable webaudio.  That's not great, but
eventually, webaudio will be enabled by default on Android, so we'd want
--disable-webaudio flag again.

[Ken Russell (switch to Gerrit), 2012-07-25 00:04:09]

I don't think it's possible to make the command line arguments accept a
true/false argument, so I think we should proceed with the patch in this form.

LGTM from my standpoint but someone on Android like Peter Beverloo should review
it too. You'll also need OWNERS reviews for the directories you're touching.

[Wei James(wistoch), 2012-07-25 01:31:34]

On 2012/07/25 00:04:09, kbr wrote:
> I don't think it's possible to make the command line arguments accept a
> true/false argument, so I think we should proceed with the patch in this form.
> 
> LGTM from my standpoint but someone on Android like Peter Beverloo should
review
> it too. You'll also need OWNERS reviews for the directories you're touching.

thanks 
+jam for content/public/
+sky for content/browser/
+jamesr for content/renderer/

[Wei James(wistoch), 2012-07-25 01:33:57]

+jam for content/public/
+sky for content/browser/
+jamesr for content/renderer/

[jam, 2012-07-25 02:06:56]

lgtm

[sky, 2012-07-25 04:39:36]

LGTM

[Peter Beverloo, 2012-07-25 08:57:47]

LGTM from Android's side.

[Wei James(wistoch), 2012-07-26 01:45:27]

+piman for content/renderer/

[piman, 2012-07-26 01:46:06]

lgtm

[commit-bot: I haz the power, 2012-07-26 01:49:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/james.wei@intel.com/10810034/1

[commit-bot: I haz the power, 2012-07-26 04:49:06]

Change committed as 148516