Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 10810031: [Mac] In all the plists, define the LSMinimumSystemVersion based on MACOSX_DEPLOYMENT_TARGET. (Closed)

Created:
8 years, 5 months ago by Robert Sesek
Modified:
8 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, sanjeevr, sadrul, ben+watch_chromium.org, wez+watch_chromium.org, amit, hclam+watch_chromium.org, jam, garykac+watch_chromium.org, joi+watch-content_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, simonmorris+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Mac] In all the plists, define the LSMinimumSystemVersion based on MACOSX_DEPLOYMENT_TARGET. The LSMinimumSystemVersion must be of the form |n.n.n| [1] but the MACOSX_DEPLOYMENT_TARGET is only |n.n|, so add an extra |.0| to the value in the plist key. [1] https://developer.apple.com/library/mac/#documentation/CoreFoundation/Conceptual/CFBundles/BundleTypes/BundleTypes.html BUG=137676 TEST=none TBR=mac people Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M ash/shell/cocoa/app-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/app-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/app_mode-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/helper-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/mac/app-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/mac/helper-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/remoting_me2me_host-Info.plist View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Sesek
8 years, 5 months ago (2012-07-20 01:18:25 UTC) #1
Nico
lgtm (ninja processes this correctly, right?)
8 years, 5 months ago (2012-07-20 01:20:50 UTC) #2
Robert Sesek
On 2012/07/20 01:20:50, Nico wrote: > lgtm > > (ninja processes this correctly, right?) Yes. ...
8 years, 5 months ago (2012-07-20 01:22:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10810031/1
8 years, 5 months ago (2012-07-20 01:22:26 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-20 03:03:32 UTC) #5
Change committed as 147607

Powered by Google App Engine
This is Rietveld 408576698