Issue 10810027: IWYU and other random cleanup in chrome/browser/ui.

Issue 10810027: IWYU and other random cleanup in chrome/browser/ui. (Closed)

Created:
8 years, 5 months ago by Lei Zhang

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

IWYU and other random cleanup in chrome/browser/ui. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149249

Patch Set 1 : #

Total comments: 1

Patch Set 2 : rebase #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -14 lines)			Patch
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/alarms/alarms_api_unittest.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/discovery/discovery_api_unittest.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/external_protocol/external_protocol_handler.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/feedback/feedback_util.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/printing/print_dialog_cloud.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser.h	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1	3 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/reload_button_gtk.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/unload_controller.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

There's also a bunch of files that use g_browser_process. They should really be #including browser_process.h ...

8 years, 5 months ago (2012-07-19 22:35:17 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10810027/14001

8 years, 4 months ago (2012-07-31 18:06:43 UTC) #4

Change committed as 149249

Expand Messages | Collapse Messages