Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 10810025: Update ninja to v120715 (Closed)

Created:
8 years, 5 months ago by Nico
Modified:
8 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, gavinp
Visibility:
Public.

Description

Update ninja to v120715 On both mac and linux, I ran: git checkout release-120715 ninja ./ninja ninja_test ./ninja_test # all passed strip ninja Changes since the last push: * ninja now has a functional -V flag that prints version information * ninja is a lot faster. On my MBP, empty builds go from 1.8s to 1.1s, on my linux box from 1.4s to 0.9s * ninja now has a -l N flag to do parallelsim based on load average On linux, the binary grew 24 bytes, from 129920 to 129944. I used gcc 4.4.3 to build ninja. On mac, it grew from 4200 byte from 120904 to 125104 (likely caused by me using a newer clang). I used clang r159409 to build ninja. TBR=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147557

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M ninja-linux64 View Binary file 0 comments Download
M ninja-mac View Binary file 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
8 years, 5 months ago (2012-07-19 22:17:14 UTC) #1
scottmg
lgtm
8 years, 5 months ago (2012-07-19 22:32:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10810025/8001
8 years, 5 months ago (2012-07-19 22:37:36 UTC) #3
commit-bot: I haz the power
Presubmit check for 10810025-8001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-19 22:40:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10810025/8001
8 years, 5 months ago (2012-07-19 22:43:50 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 22:46:21 UTC) #6
Change committed as 147557

Powered by Google App Engine
This is Rietveld 408576698