Dump number of symbols in the isolate symbol table before shutting down an isolate under the --trac…

vm/symbols.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/symbols.h"
 
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/raw_object.h"
@@ skipping 29 matching lines @@
 
   // Setup the symbol table used within the String class.
   const Array& array = Array::Handle(Array::New(kInitialSymbolTableSize + 1));
 
   // Last element contains the count of used slots.
   array.SetAt(kInitialSymbolTableSize, Smi::Handle(Smi::New(0)));
   isolate->object_store()->set_symbol_table(array);
 }
 
 
+intptr_t Symbols::UsedCount(Isolate* isolate) {

[cshapiro, 2012/07/25 02:57:20]

Naming this method Size and renaming the variable table_size to capacity would
make things slightly more consistent with other ADTs in the VM (and elsewhere,
too).

[siva, 2012/07/25 23:41:15]

I called the method 'Size' as it is a count of entries in the table and I
renamed the variable name table_size_index (index in which we store the table
size)

On 2012/07/25 02:57:20, cshapiro wrote:

+  ASSERT(isolate != NULL);
+  Array& symbol_table = Array::Handle(isolate,
+                                      isolate->object_store()->symbol_table());
+  intptr_t table_size = symbol_table.Length() - 1;
+  Smi& used = Smi::Handle();
+  used ^= symbol_table.At(table_size);
+  return used.Value();
+}
+
+
 void Symbols::Add(const Array& symbol_table, const String& str) {
   // Should only be run by the vm isolate.
   ASSERT(Isolate::Current() == Dart::vm_isolate());
   intptr_t hash = str.Hash();
   intptr_t index = FindIndex(symbol_table, str, 0, str.Length(), hash);
   ASSERT(symbol_table.At(index) == String::null());
   InsertIntoSymbolTable(symbol_table, str, index);
 }
 
 
@@ skipping 200 matching lines @@
   String& symbol = String::Handle();
   symbol ^= symbol_table.At(index);
   while (!symbol.IsNull() && !symbol.Equals(str, begin_index, len)) {
     index = (index + 1) % table_size;  // Move to next element.
     symbol ^= symbol_table.At(index);
   }
   return index;  // Index of symbol if found or slot into which to add symbol.
 }
 
 }  // namespace dart