Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: chrome/browser/extensions/menu_manager.cc

Issue 10809094: Context Menus now uses the JSON Schema Compiler. (Closed) Base URL: http://git.chromium.org/chromium/src.git@json_functions_as_properties
Patch Set: * Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/menu_manager.cc
diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc
index 92154f981e8a0f222515f477b05df60376a12daa..13f6cdb5b57134064984091d371cb4eaa6df298c 100644
--- a/chrome/browser/extensions/menu_manager.cc
+++ b/chrome/browser/extensions/menu_manager.cc
@@ -268,6 +268,25 @@ bool MenuItem::PopulateURLPatterns(const DictionaryValue& properties,
return true;
}
+bool MenuItem::PopulateURLPatterns(
+ std::vector<std::string>* document_url_patterns,
+ std::vector<std::string>* target_url_patterns,
+ std::string* error) {
+ if (document_url_patterns) {
+ if (!document_url_patterns_.Populate(
+ *document_url_patterns, URLPattern::SCHEME_ALL, true, error)) {
+ return false;
+ }
+ }
+ if (target_url_patterns) {
+ if (!target_url_patterns_.Populate(
+ *target_url_patterns, URLPattern::SCHEME_ALL, true, error)) {
+ return false;
+ }
+ }
+ return true;
+}
+
MenuManager::MenuManager(Profile* profile)
: profile_(profile) {
registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED,

Powered by Google App Engine
This is Rietveld 408576698