Revert "Revert 147986 - [Android] Add remaining build/common.gypi changes from downstream and strip…

Revert "Revert 147986 - [Android] Add remaining build/common.gypi changes from downstream and strip NOTIMPLEMENTED()s from official builds."

Relanding http://codereview.chromium.org/10816039/ but removing the
clang parts and fixing x86.

This reverts commit 7fc96c8b734fc9bc8152329d99e8ee3f3de14a65.

BUG=137569
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148338

[Yaron, 2012-07-24 23:24:43]

Second attempt at this. I decided to split off the clang part to a separate
change and possibly handled by someone more familiar with our clang configs.

The first patchset has the change as it was so you can see what the fixes
entail.

[John Grabowski, 2012-07-24 23:33:31]

LGTM

http://codereview.chromium.org/10809081/diff/2003/build/android/gtest_filter/...
File build/android/gtest_filter/base_unittests_disabled (right):

http://codereview.chromium.org/10809081/diff/2003/build/android/gtest_filter/...
build/android/gtest_filter/base_unittests_disabled:2:
StackTrace.DebugPrintBacktrace
Perhaps comment we will never support StackTrace?
And if so, perhaps better to disable StackTrace.*?

http://codereview.chromium.org/10809081/diff/2003/build/android/gtest_filter/...
File build/android/gtest_filter/net_unittests_disabled (right):

http://codereview.chromium.org/10809081/diff/2003/build/android/gtest_filter/...
build/android/gtest_filter/net_unittests_disabled:120:
PrioritizedDispatcherTest.CancelNull
bugs for these 2?

[Yaron, 2012-07-24 23:43:01]

http://codereview.chromium.org/10809081/diff/2003/build/android/gtest_filter/...
File build/android/gtest_filter/base_unittests_disabled (right):

http://codereview.chromium.org/10809081/diff/2003/build/android/gtest_filter/...
build/android/gtest_filter/base_unittests_disabled:2:
StackTrace.DebugPrintBacktrace
On 2012/07/24 23:33:32, John Grabowski wrote:
> Perhaps comment we will never support StackTrace?
> And if so, perhaps better to disable StackTrace.*?

Done.

http://codereview.chromium.org/10809081/diff/2003/build/android/gtest_filter/...
File build/android/gtest_filter/net_unittests_disabled (right):

http://codereview.chromium.org/10809081/diff/2003/build/android/gtest_filter/...
build/android/gtest_filter/net_unittests_disabled:120:
PrioritizedDispatcherTest.CancelNull
On 2012/07/24 23:33:32, John Grabowski wrote:
> bugs for these 2?

Err, it might not be clear but they're also death tests. I'll file a bug to
handle death tests in a consistent manner going forward (not sure if there's a
gtest flag or how GTEST_HAS_DEATH_TEST is supposed to be managed).

[John Grabowski, 2012-07-24 23:51:31]

http://codereview.chromium.org/10809081/diff/2003/build/android/gtest_filter/...
File build/android/gtest_filter/net_unittests_disabled (right):

http://codereview.chromium.org/10809081/diff/2003/build/android/gtest_filter/...
build/android/gtest_filter/net_unittests_disabled:120:
PrioritizedDispatcherTest.CancelNull
On 2012/07/24 23:43:01, Yaron wrote:
> On 2012/07/24 23:33:32, John Grabowski wrote:
> > bugs for these 2?
> 
> Err, it might not be clear but they're also death tests. I'll file a bug to
> handle death tests in a consistent manner going forward (not sure if there's a
> gtest flag or how GTEST_HAS_DEATH_TEST is supposed to be managed).

Oh; that wasn't clear, since I would have guessed *DeathTest* covers all death
tests.  Maybe just update the comment then.

[Mark Mentovai, 2012-07-25 12:07:09]

LGTM

[commit-bot: I haz the power, 2012-07-25 14:33:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10809081/5003

[commit-bot: I haz the power, 2012-07-25 16:17:59]

Change committed as 148338