Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 10809076: Move CachedRanges out and add support for checksum. (Closed)

Created:
8 years, 5 months ago by kaiwang
Modified:
8 years, 4 months ago
CC:
chromium-reviews, erikwright (departed), MAD, Ilya Sherman, jar (doing other things), brettw-cc_chromium.org
Visibility:
Public.

Description

This is a copy of http://codereview.chromium.org/10796047/ It was reverted in https://chromiumcodereview.appspot.com/10807083/ because it unveiled a problem of build_nexe.py on Windows (http://crbug.com/138687). Now the bug is fixed so submit this CL again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -129 lines) Patch
M base/base.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M base/base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A base/metrics/bucket_ranges.h View 1 chunk +69 lines, -0 lines 0 comments Download
A base/metrics/bucket_ranges.cc View 1 chunk +139 lines, -0 lines 0 comments Download
A base/metrics/bucket_ranges_unittest.cc View 1 chunk +75 lines, -0 lines 0 comments Download
M base/metrics/histogram.h View 11 chunks +16 lines, -52 lines 0 comments Download
base/metrics/histogram.cc View 8 chunks +10 lines, -36 lines 0 comments Download
M base/metrics/histogram_unittest.cc View 4 chunks +19 lines, -15 lines 0 comments Download
M base/metrics/statistics_recorder.h View 4 chunks +12 lines, -12 lines 0 comments Download
M base/metrics/statistics_recorder.cc View 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
No reviewers yet.
8 years, 5 months ago (2012-07-25 17:50:18 UTC) #1
jar (doing other things)
nit: Please add reference to the original landing CL, and add me as a listed ...
8 years, 5 months ago (2012-07-25 18:25:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaiwang@chromium.org/10809076/1
8 years, 5 months ago (2012-07-25 18:29:33 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 20:02:51 UTC) #4
Change committed as 148391

Powered by Google App Engine
This is Rietveld 408576698