Issue 10809061: Remove promo send email from tab android.

Issue 10809061: Remove promo send email from tab android. (Closed)

Created:
8 years, 5 months ago by Ted C

Modified:
8 years, 5 months ago

Reviewers:
felipeg, Yaron, aruslan

CC:
chromium-reviews, aurimas (slooooooooow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove promo send email from tab android. Move the functionality into helper that we can use for issuing android intents. BUG=136785 TEST=run 'make browser' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148036

Patch Set 1 #

Total comments: 4

Patch Set 2 : Resolve review comments. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -10 lines)			Patch
A	chrome/android/java/src/org/chromium/chrome/browser/IntentHelper.java	View	1	1 chunk	+69 lines, -0 lines	0 comments	Download
A	chrome/browser/android/intent_helper.h	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
A	chrome/browser/android/intent_helper.cc	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
M	chrome/browser/android/tab_android.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Yaron

lgtm aurimas: if this lands before you, you can add it to your jni_registrar patch. ...

8 years, 5 months ago (2012-07-23 23:49:43 UTC) #3

Ted C

https://chromiumcodereview.appspot.com/10809061/diff/1/chrome/android/java/src/org/chromium/chrome/browser/IntentHelper.java File chrome/android/java/src/org/chromium/chrome/browser/IntentHelper.java (right): https://chromiumcodereview.appspot.com/10809061/diff/1/chrome/android/java/src/org/chromium/chrome/browser/IntentHelper.java#newcode34 chrome/android/java/src/org/chromium/chrome/browser/IntentHelper.java:34: * @param subj The subject of the email. On ...

8 years, 5 months ago (2012-07-24 00:28:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10809061/4001

8 years, 5 months ago (2012-07-24 00:35:08 UTC) #5

Change committed as 148036

Expand Messages | Collapse Messages