Use CFBundleVersion for product_version on iOS

Use CFBundleVersion for product_version on iOS

On OS X, CFBundleVersion is used by LaunchServices, and must follow
specific formatting rules, so the four-part Chrome version is in
CFBundleShortVersionString. On iOS, however, CFBundleVersion can be the
full version, but CFBundleShortVersionString has a policy-enfoced limit
of three version components.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148081

[Mark Mentovai, 2012-07-23 20:48:43]

LGTM

https://chromiumcodereview.appspot.com/10809059/diff/1002/base/file_version_i...
File base/file_version_info_mac.mm (right):

https://chromiumcodereview.appspot.com/10809059/diff/1002/base/file_version_i...
base/file_version_info_mac.mm:65: // CFBundleShortVersionString. On iOS,
however, CFBundleVersion can be the
Oh, wow.

[stuartmorgan, 2012-07-24 09:37:55]

https://chromiumcodereview.appspot.com/10809059/diff/1002/base/file_version_i...
File base/file_version_info_mac.mm (right):

https://chromiumcodereview.appspot.com/10809059/diff/1002/base/file_version_i...
base/file_version_info_mac.mm:65: // CFBundleShortVersionString. On iOS,
however, CFBundleVersion can be the
On 2012/07/23 20:48:43, Mark Mentovai wrote:
> Oh, wow.

Yeah, having completely different arbitrary rules for versioning between
platforms is pretty awesome. At least on iOS it's documented, so you don't have
to reverse-engineer the maximums for each component :P

[commit-bot: I haz the power, 2012-07-24 09:38:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10809059/1002

[commit-bot: I haz the power, 2012-07-24 11:19:09]

Change committed as 148081