Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: content/browser/renderer_host/render_widget_helper.cc

Issue 10809051: Fix regression of bug 205 where a plugin in a window shown with window.open may not have the correc… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_helper.cc
===================================================================
--- content/browser/renderer_host/render_widget_helper.cc (revision 147827)
+++ content/browser/renderer_host/render_widget_helper.cc (working copy)
@@ -143,9 +143,7 @@
}
bool RenderWidgetHelper::WaitForBackingStoreMsg(
- int render_widget_id,
- const base::TimeDelta& max_delay,
- IPC::Message* msg) {
+ int render_widget_id, const base::TimeDelta& max_delay, IPC::Message* msg) {
base::TimeTicks time_start = base::TimeTicks::Now();
for (;;) {
@@ -189,6 +187,17 @@
return false;
}
+void RenderWidgetHelper::ResumeRequestsForView(int route_id) {
+ // We only need to resume blocked requests if we used a valid route_id.
+ // See CreateNewWindow.
+ if (route_id != MSG_ROUTING_NONE) {
+ BrowserThread::PostTask(
+ BrowserThread::IO, FROM_HERE,
+ base::Bind(&RenderWidgetHelper::OnResumeRequestsForView,
+ this, route_id));
+ }
+}
+
void RenderWidgetHelper::DidReceiveBackingStoreMsg(const IPC::Message& msg) {
int render_widget_id = msg.routing_id();
@@ -288,17 +297,9 @@
RenderViewHostImpl::FromID(render_process_id_, params.opener_id);
if (host)
host->CreateNewWindow(route_id, params, session_storage_namespace);
-
- // We only need to resume blocked requests if we used a valid route_id.
- // See CreateNewWindow.
- if (route_id != MSG_ROUTING_NONE) {
- BrowserThread::PostTask(
- BrowserThread::IO, FROM_HERE,
- base::Bind(&RenderWidgetHelper::OnCreateWindowOnIO, this, route_id));
- }
}
-void RenderWidgetHelper::OnCreateWindowOnIO(int route_id) {
+void RenderWidgetHelper::OnResumeRequestsForView(int route_id) {
resource_dispatcher_host_->ResumeBlockedRequestsForRoute(
render_process_id_, route_id);
}

Powered by Google App Engine
This is Rietveld 408576698