Fix library scan of loose files

Fix library scan of loose files
Committed: https://code.google.com/p/dart/source/detail?r=9777

[danrubel, 2012-07-20 13:51:08]

* when scanning, discard libraries that have no directives when source'd by
another library
* move utility methods into common utility class
* new library scan test
* remove outdated analysis tests

[scheglov, 2012-07-20 14:20:42]

lgtm

[Brian Wilkerson, 2012-07-20 15:22:07]

LGTM unless it needs to change based on my comment

https://chromiumcodereview.appspot.com/10809037/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java
(right):

https://chromiumcodereview.appspot.com/10809037/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java:132:
if (libraryFiles.add(libraryFile)) {
ArrayList.add() always returns true. Did you intend to change the type of
libraryFiles to be a Set, or was this just an oversight?

[danrubel, 2012-07-20 15:48:08]

https://chromiumcodereview.appspot.com/10809037/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java
(right):

https://chromiumcodereview.appspot.com/10809037/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java:132:
if (libraryFiles.add(libraryFile)) {
On 2012/07/20 15:22:07, Brian Wilkerson wrote:
> ArrayList.add() always returns true. Did you intend to change the type of
> libraryFiles to be a Set, or was this just an oversight?

Good catch! Fixing now in subsequent CL.