Make spacing between uber tray items consistent with UI spec.

Make spacing between uber tray items consistent with M22 UI spec.
For bottom aligned launcher:
7 pixel padding around left/right of text tray item. 
1 pixel padding around all sides of image tray item.
1 pixel around all sides of the uber tray (SystemTrayContainer).

For vertical aligned launcher:
1 pixel padding around all sides of the image tray item.
4 pixel padding above and below the text tray item, and center the text horizontally.
1 pixel around all sides of the uber tray (SystemTrayContainer).



BUG=125261
TEST=The spacing between urber tray items should be consistent.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147963

[sadrul, 2012-07-19 16:46:28]

http://codereview.chromium.org/10809008/diff/1/ash/system/ime/tray_ime.cc
File ash/system/ime/tray_ime.cc (right):

http://codereview.chromium.org/10809008/diff/1/ash/system/ime/tray_ime.cc#new...
ash/system/ime/tray_ime.cc:255:
ash::Shell::GetInstance()->system_tray()->shelf_alignment());
Looks like this is necessary in all CreateTrayView. I would suggest either
sending the alignment as a param, or calling UpdateAfterShelfAlignmentChange
after the call to CreateTrayView in SystemTray.

http://codereview.chromium.org/10809008/diff/1/ash/system/ime/tray_ime.cc#new...
ash/system/ime/tray_ime.cc:305: SetTrayLabelItemBorder(tray_label_, alignment);
This also seems to be necessary for all items. So I would rather just call
SetTrayLabelItemBorder from the default implementation, instead of overriding
this for every item.

http://codereview.chromium.org/10809008/diff/1/ash/system/tray/tray_item_view.h
File ash/system/tray/tray_item_view.h (right):

http://codereview.chromium.org/10809008/diff/1/ash/system/tray/tray_item_view...
ash/system/tray/tray_item_view.h:42: 
-extra new line

[jennyz, 2012-07-19 18:33:33]

http://codereview.chromium.org/10809008/diff/1/ash/system/ime/tray_ime.cc
File ash/system/ime/tray_ime.cc (right):

http://codereview.chromium.org/10809008/diff/1/ash/system/ime/tray_ime.cc#new...
ash/system/ime/tray_ime.cc:255:
ash::Shell::GetInstance()->system_tray()->shelf_alignment());
On 2012/07/19 16:46:28, sadrul wrote:
> Looks like this is necessary in all CreateTrayView. I would suggest either
> sending the alignment as a param, or calling UpdateAfterShelfAlignmentChange
> after the call to CreateTrayView in SystemTray.

Done.

http://codereview.chromium.org/10809008/diff/1/ash/system/ime/tray_ime.cc#new...
ash/system/ime/tray_ime.cc:305: SetTrayLabelItemBorder(tray_label_, alignment);
On 2012/07/19 16:46:28, sadrul wrote:
> This also seems to be necessary for all items. So I would rather just call
> SetTrayLabelItemBorder from the default implementation, instead of overriding
> this for every item.
This may require some more refactoring, since SystemTrayItem does not own the
tray_view from CreateTrayView, and each kind of tray may create different kind
of view object. TrayImageItem does cover a lot of tray items, so that we only
need to handle UpdateAfterShelfAlignment in that class.   But others like
TrayUser, TrayNetwork, TrayPower, TrayIME, TrayDate, etc, each create its own
tray_view, and knows what kind of  view it created by themselves, it could be
either an image or label. So it is hard to handle in the default handler in
parent class. One possible refactoring may be to add some base class like the
way we did for TrayImageItem for label tray item, and handle the default
UpdateAfterShelfAlignment there, any suggestion? And do we want to do this for
this cl?

http://codereview.chromium.org/10809008/diff/1/ash/system/tray/tray_item_view.h
File ash/system/tray/tray_item_view.h (right):

http://codereview.chromium.org/10809008/diff/1/ash/system/tray/tray_item_view...
ash/system/tray/tray_item_view.h:42: 
On 2012/07/19 16:46:28, sadrul wrote:
> -extra new line

Done.

[sadrul, 2012-07-23 16:25:03]

Refactoring would probably be useful. But if we don't refactor right now, see
comment:

http://codereview.chromium.org/10809008/diff/5001/ash/system/tray/system_tray...
File ash/system/tray/system_tray_item.h (right):

http://codereview.chromium.org/10809008/diff/5001/ash/system/tray/system_tray...
ash/system/tray/system_tray_item.h:77: ShelfAlignment alignment);
Until the refactoring, these do not fit in well in SystemTrayItem. Perhaps move
these two into tray_views instead? (similar to SetupLabelForTray)

[jennyz, 2012-07-23 17:22:42]

http://codereview.chromium.org/10809008/diff/5001/ash/system/tray/system_tray...
File ash/system/tray/system_tray_item.h (right):

http://codereview.chromium.org/10809008/diff/5001/ash/system/tray/system_tray...
ash/system/tray/system_tray_item.h:77: ShelfAlignment alignment);
On 2012/07/23 16:25:03, sadrul wrote:
> Until the refactoring, these do not fit in well in SystemTrayItem. Perhaps
move
> these two into tray_views instead? (similar to SetupLabelForTray)

Done.

[sadrul, 2012-07-23 20:55:24]

LGTM

[commit-bot: I haz the power, 2012-07-23 21:07:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/10809008/13002