Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: chrome/browser/resources/web_dev_style/js_checker.py

Issue 10809005: Options: Rename chrome/browser/resources/options2 -> chrome/browser/resources/options. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for Chromium JS resources. 5 """Presubmit script for Chromium JS resources.
6 6
7 See chrome/browser/resources/PRESUBMIT.py 7 See chrome/browser/resources/PRESUBMIT.py
8 """ 8 """
9 9
10 class JSChecker(object): 10 class JSChecker(object):
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 # resources/ we can get rid of this function. 72 # resources/ we can get rid of this function.
73 path = self.input_api.os_path 73 path = self.input_api.os_path
74 resources = self.input_api.PresubmitLocalPath() 74 resources = self.input_api.PresubmitLocalPath()
75 dirs = ( 75 dirs = (
76 path.join(resources, 'extensions'), 76 path.join(resources, 'extensions'),
77 path.join(resources, 'help'), 77 path.join(resources, 'help'),
78 path.join(resources, 'history'), 78 path.join(resources, 'history'),
79 path.join(resources, 'net_internals'), 79 path.join(resources, 'net_internals'),
80 path.join(resources, 'network_action_predictor'), 80 path.join(resources, 'network_action_predictor'),
81 path.join(resources, 'ntp4'), 81 path.join(resources, 'ntp4'),
82 path.join(resources, 'options2'), 82 path.join(resources, 'options'),
83 path.join(resources, 'print_preview'), 83 path.join(resources, 'print_preview'),
84 path.join(resources, 'profiler'), 84 path.join(resources, 'profiler'),
85 path.join(resources, 'sync_promo'), 85 path.join(resources, 'sync_promo'),
86 path.join(resources, 'tracing'), 86 path.join(resources, 'tracing'),
87 path.join(resources, 'uber'), 87 path.join(resources, 'uber'),
88 ) 88 )
89 if filename.startswith(dirs): 89 if filename.startswith(dirs):
90 return self.output_api.PresubmitError(error_text) 90 return self.output_api.PresubmitError(error_text)
91 else: 91 else:
92 return self.output_api.PresubmitPromptWarning(error_text) 92 return self.output_api.PresubmitPromptWarning(error_text)
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
207 '\n'.join(error_lines), f.AbsoluteLocalPath())) 207 '\n'.join(error_lines), f.AbsoluteLocalPath()))
208 208
209 if results: 209 if results:
210 results.append(self.output_api.PresubmitNotifyResult( 210 results.append(self.output_api.PresubmitNotifyResult(
211 'See the JavaScript style guide at ' 211 'See the JavaScript style guide at '
212 'http://www.chromium.org/developers/web-development-style-guide' 212 'http://www.chromium.org/developers/web-development-style-guide'
213 '#TOC-JavaScript and if you have any feedback about the JavaScript ' 213 '#TOC-JavaScript and if you have any feedback about the JavaScript '
214 'PRESUBMIT check, contact tbreisacher@chromium.org')) 214 'PRESUBMIT check, contact tbreisacher@chromium.org'))
215 215
216 return results 216 return results
OLDNEW
« no previous file with comments | « chrome/browser/resources/sync_promo/sync_promo.js ('k') | chrome/browser/ui/webui/options2/options_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698