gdata: Add authentication status section to chrome:drive-internals

gdata: Add authentication status section to chrome:drive-internals

BUG=135328
TEST=auth status is shown in chrome:drive-internals properly

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148544

[achuithb, 2012-07-24 23:53:20]

http://codereview.chromium.org/10808116/diff/1/chrome/browser/ui/webui/chrome...
File chrome/browser/ui/webui/chromeos/drive_internals_ui.cc (right):

http://codereview.chromium.org/10808116/diff/1/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:22: class
DriveInternalsWebUIHandler : public content::WebUIMessageHandler {
Why not put this in anonymous scope?

http://codereview.chromium.org/10808116/diff/1/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:28:
~DriveInternalsWebUIHandler() {
Should this be virtual?

http://codereview.chromium.org/10808116/diff/1/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:32: virtual void
RegisterMessages() OVERRIDE {
This can be private, I believe.

http://codereview.chromium.org/10808116/diff/1/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:45:
DCHECK(system_service);
Is it possible to launch this page in guest/incognito?

[satorux1, 2012-07-25 00:32:23]

http://codereview.chromium.org/10808116/diff/1/chrome/browser/ui/webui/chrome...
File chrome/browser/ui/webui/chromeos/drive_internals_ui.cc (right):

http://codereview.chromium.org/10808116/diff/1/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:22: class
DriveInternalsWebUIHandler : public content::WebUIMessageHandler {
On 2012/07/24 23:53:20, achuith.bhandarkar wrote:
> Why not put this in anonymous scope?

Done.

http://codereview.chromium.org/10808116/diff/1/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:28:
~DriveInternalsWebUIHandler() {
On 2012/07/24 23:53:20, achuith.bhandarkar wrote:
> Should this be virtual?

Done.

http://codereview.chromium.org/10808116/diff/1/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:32: virtual void
RegisterMessages() OVERRIDE {
On 2012/07/24 23:53:20, achuith.bhandarkar wrote:
> This can be private, I believe.

Done.

http://codereview.chromium.org/10808116/diff/1/chrome/browser/ui/webui/chrome...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:45:
DCHECK(system_service);
On 2012/07/24 23:53:20, achuith.bhandarkar wrote:
> Is it possible to launch this page in guest/incognito?

Good point. Will |system_service| be NULL in the guest/incognito mode? I cannot
test it now. Changed it to handle NULL anyway.

[achuithb, 2012-07-25 00:37:00]

lgtm

http://codereview.chromium.org/10808116/diff/5001/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/drive_internals_ui.cc (right):

http://codereview.chromium.org/10808116/diff/5001/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:47: // |system_service|
may be NULL in the guest/incognito mode.
You may want to test this. Some chrome:// pages automatically load only on
non-incognito windows.

[satorux1, 2012-07-25 20:03:47]

On 2012/07/25 00:37:00, achuith.bhandarkar wrote:
> lgtm
> 
>
http://codereview.chromium.org/10808116/diff/5001/chrome/browser/ui/webui/chr...
> File chrome/browser/ui/webui/chromeos/drive_internals_ui.cc (right):
> 
>
http://codereview.chromium.org/10808116/diff/5001/chrome/browser/ui/webui/chr...
> chrome/browser/ui/webui/chromeos/drive_internals_ui.cc:47: // |system_service|
> may be NULL in the guest/incognito mode.
> You may want to test this. Some chrome:// pages automatically load only on
> non-incognito windows.

Tested. Confirmed that it was NULL in the incognito mode. I wasn't able to test
with the guest mode, the guest mode didn't work on Linux desktop, but I guess
the result is the same.