Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5291)

Unified Diff: chrome/browser/resources/options2/certificate_tree.js

Issue 10808114: Merge 146920 - Fix certificate manager buttons never becoming clickable. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1180/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options2/certificate_manager.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options2/certificate_tree.js
===================================================================
--- chrome/browser/resources/options2/certificate_tree.js (revision 148228)
+++ chrome/browser/resources/options2/certificate_tree.js (working copy)
@@ -7,12 +7,45 @@
/** @const */ var TreeItem = cr.ui.TreeItem;
/**
+ * Creates a new tree folder for certificate data.
+ * @param {Object=} data Data used to create a certificate tree folder.
+ * @constructor
+ * @extends {TreeItem}
+ */
+ function CertificateTreeFolder(data) {
+ data.isCert = false;
+ var treeFolder = new TreeItem({
+ label: data.name,
+ data: data
+ });
+ treeFolder.__proto__ = CertificateTreeFolder.prototype;
+
+ if (data.icon)
+ treeFolder.icon = data.icon;
+
+ return treeFolder;
+ }
+
+ CertificateTreeFolder.prototype = {
+ __proto__: TreeItem.prototype,
+
+ /**
+ * The tree path id/.
+ * @type {string}
+ */
+ get pathId() {
+ return this.data.id;
+ }
+ };
+
+ /**
* Creates a new tree item for certificate data.
* @param {Object=} data Data used to create a certificate tree item.
* @constructor
* @extends {TreeItem}
*/
function CertificateTreeItem(data) {
+ data.isCert = true;
// TODO(mattm): other columns
var treeItem = new TreeItem({
label: data.name,
@@ -20,9 +53,8 @@
});
treeItem.__proto__ = CertificateTreeItem.prototype;
- if (data.icon) {
+ if (data.icon)
treeItem.icon = data.icon;
- }
if (data.untrusted) {
var badge = document.createElement('span');
@@ -43,12 +75,7 @@
* @type {string}
*/
get pathId() {
- var parent = this.parentItem;
- if (parent && parent instanceof CertificateTreeItem) {
- return parent.pathId + ',' + this.data.id;
- } else {
- return this.data.id;
- }
+ return this.parentItem.pathId + ',' + this.data.id;
}
};
@@ -105,7 +132,7 @@
var subnodes = nodesData[i]['subnodes'];
delete nodesData[i]['subnodes'];
- var item = new CertificateTreeItem(nodesData[i]);
+ var item = new CertificateTreeFolder(nodesData[i]);
this.addAt(item, i);
for (var j = 0; j < subnodes.length; ++j) {
« no previous file with comments | « chrome/browser/resources/options2/certificate_manager.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698