Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 10808109: Remove Linux-specific mapping from NO_ELLIPSIS to MULTI_LINE in canvas_skia.cc. (Closed)

Created:
8 years, 5 months ago by Alexei Svitkine (slow)
Modified:
8 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Remove Linux-specific mapping from NO_ELLIPSIS to MULTI_LINE in canvas_skia.cc. BUG=107357, 133638 TEST=http://crbug.com/133638 is fixed and there are no other visual regressions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M ui/gfx/canvas_skia.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
Hey Scott, I couldn't find any issues with killing this mapping. I had originally put ...
8 years, 5 months ago (2012-07-24 20:24:42 UTC) #1
sky
LGTM I don't know any places. I wouldn't be surprised if they are there, you'll ...
8 years, 5 months ago (2012-07-24 21:38:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10808109/1
8 years, 5 months ago (2012-07-24 21:56:29 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 23:19:09 UTC) #4
Change committed as 148243

Powered by Google App Engine
This is Rietveld 408576698