Issue 10808108: gdata: Expose authentication states from GDataDocumentsService.

Issue 10808108: gdata: Expose authentication states from GDataDocumentsService. (Closed)

Created:
8 years, 5 months ago by satorux1

Modified:
8 years, 5 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Expose authentication states from GDataDocumentsService. IsFullyAuthenticated() and IsPartiallyAuthenticated() will be used in the debug console for Drive (chrome::drive-internals). BUG=135328 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148228

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -0 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_documents_service.h	View	2 chunks	+9 lines, -0 lines	2 comments	Download
M	chrome/browser/chromeos/gdata/gdata_documents_service.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/mock_gdata_documents_service.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

lgtm https://chromiumcodereview.appspot.com/10808108/diff/1/chrome/browser/chromeos/gdata/gdata_documents_service.h File chrome/browser/chromeos/gdata/gdata_documents_service.h (right): https://chromiumcodereview.appspot.com/10808108/diff/1/chrome/browser/chromeos/gdata/gdata_documents_service.h#newcode192 chrome/browser/chromeos/gdata/gdata_documents_service.h:192: virtual bool IsPartiallyAuthenticated() const = 0; nit since ...

8 years, 5 months ago (2012-07-24 20:31:08 UTC) #2

satorux1

8 years, 5 months ago (2012-07-24 20:52:01 UTC) #3

http://codereview.chromium.org/10808108/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_documents_service.h (right):

http://codereview.chromium.org/10808108/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_documents_service.h:192: virtual bool
IsPartiallyAuthenticated() const = 0;
On 2012/07/24 20:31:08, Daniel Erat wrote:
> nit since you're just using the existing names in this change: Do "fully
> authenticated" and "partially authenticated" have have well-known
present/fresh
> vs. present meanings when talking about OAuth2 tokens?  If not, names like
> HasFreshAuthToken() and HasAuthToken() would probably be more descriptive. 
I'm
> also a bit concerned that people may think that IsPartiallyAuthenticated()
> implies !IsFullyAuthenticated().

That's a good suggestion. I'll create a patch to rename these methods.

Expand Messages | Collapse Messages