Add EventFilter for LauncherTooltip (2nd try).

Add EventFilter for LauncherTooltip (2nd try).

Now it monitors mouse/touch/gesture events and hides the tooltip if necessary.
Previous CL (crrev.com/148079) was reverted since it causes use-after-free error.
It happens when the 'LauncherTooltipBubble' widget exists but LauncherTooltipManager
is already released.  In that case, the widget's release will cause WindowClosing()
which calls host_->OnBubbleClosed(), but host_ is already released.
Thus I'd make sure to introduce a method to set host_ to NULL in case that
LauncherTooltipManager explicitly clean-up the Bubble.

R=derat@chromium.org
BUG=137678
TEST=manually checked on linux, aura_shell_unittests passed with asan


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148308

[Daniel Erat, 2012-07-24 16:39:50]

lgtm

http://codereview.chromium.org/10808102/diff/1/ash/launcher/launcher_tooltip_...
File ash/launcher/launcher_tooltip_manager.cc (right):

http://codereview.chromium.org/10808102/diff/1/ash/launcher/launcher_tooltip_...
ash/launcher/launcher_tooltip_manager.cc:248:
MessageLoopForUI::current()->PostTask(
nit: is it worthwhile to move this into a PostCloseTask() helper method, since
it's duplicated several times?

http://codereview.chromium.org/10808102/diff/1/ash/launcher/launcher_tooltip_...
File ash/launcher/launcher_tooltip_manager.h (right):

http://codereview.chromium.org/10808102/diff/1/ash/launcher/launcher_tooltip_...
ash/launcher/launcher_tooltip_manager.h:14: #include "ui/aura/event_filter.h"
nit: fix alphabetization

[Jun Mukai, 2012-07-25 07:10:05]

http://codereview.chromium.org/10808102/diff/1/ash/launcher/launcher_tooltip_...
File ash/launcher/launcher_tooltip_manager.cc (right):

http://codereview.chromium.org/10808102/diff/1/ash/launcher/launcher_tooltip_...
ash/launcher/launcher_tooltip_manager.cc:248:
MessageLoopForUI::current()->PostTask(
On 2012/07/24 16:39:50, Daniel Erat wrote:
> nit: is it worthwhile to move this into a PostCloseTask() helper method, since
> it's duplicated several times?

Added CloseSoon()  thanks.

http://codereview.chromium.org/10808102/diff/1/ash/launcher/launcher_tooltip_...
File ash/launcher/launcher_tooltip_manager.h (right):

http://codereview.chromium.org/10808102/diff/1/ash/launcher/launcher_tooltip_...
ash/launcher/launcher_tooltip_manager.h:14: #include "ui/aura/event_filter.h"
On 2012/07/24 16:39:50, Daniel Erat wrote:
> nit: fix alphabetization

Done.

[commit-bot: I haz the power, 2012-07-25 09:58:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/10808102/7001

[commit-bot: I haz the power, 2012-07-25 11:17:40]

Change committed as 148308