Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc

Issue 10808097: Revert 148074 - Pass the render process id to the FrameNavigationState. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc
===================================================================
--- chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc (revision 148085)
+++ chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc (working copy)
@@ -24,51 +24,16 @@
} // namespace
-FrameNavigationState::FrameID::FrameID()
- : frame_num(-1),
- render_process_id(-1) {
-}
-
-FrameNavigationState::FrameID::FrameID(int64 frame_num,
- int render_process_id)
- : frame_num(frame_num),
- render_process_id(render_process_id) {
-}
-
-FrameNavigationState::FrameID::~FrameID() {}
-
-bool FrameNavigationState::FrameID::operator<(
- const FrameNavigationState::FrameID& other) const {
- return frame_num < other.frame_num ||
- (frame_num == other.frame_num &&
- render_process_id < other.render_process_id);
-}
-
-bool FrameNavigationState::FrameID::operator==(
- const FrameNavigationState::FrameID& other) const {
- return frame_num == other.frame_num &&
- render_process_id == other.render_process_id;
-}
-
-bool FrameNavigationState::FrameID::operator!=(
- const FrameNavigationState::FrameID& other) const {
- return !(*this == other);
-}
-
// static
-FrameNavigationState::FrameID FrameNavigationState::kInvalidFrameID =
- FrameNavigationState::FrameID(-1, -1);
-
-// static
bool FrameNavigationState::allow_extension_scheme_ = false;
FrameNavigationState::FrameNavigationState()
- : main_frame_id_(kInvalidFrameID) {
+ : main_frame_id_(-1) {
}
FrameNavigationState::~FrameNavigationState() {}
-bool FrameNavigationState::CanSendEvents(FrameID frame_id) const {
+bool FrameNavigationState::CanSendEvents(int64 frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
if (frame_state == frame_state_map_.end() ||
@@ -91,7 +56,7 @@
return false;
}
-void FrameNavigationState::TrackFrame(FrameID frame_id,
+void FrameNavigationState::TrackFrame(int64 frame_id,
const GURL& url,
bool is_main_frame,
bool is_error_page) {
@@ -112,7 +77,7 @@
frame_ids_.insert(frame_id);
}
-void FrameNavigationState::UpdateFrame(FrameID frame_id, const GURL& url) {
+void FrameNavigationState::UpdateFrame(int64 frame_id, const GURL& url) {
FrameIdToStateMap::iterator frame_state = frame_state_map_.find(frame_id);
if (frame_state == frame_state_map_.end()) {
NOTREACHED();
@@ -121,13 +86,13 @@
frame_state->second.url = url;
}
-bool FrameNavigationState::IsValidFrame(FrameID frame_id) const {
+bool FrameNavigationState::IsValidFrame(int64 frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
return (frame_state != frame_state_map_.end());
}
-GURL FrameNavigationState::GetUrl(FrameID frame_id) const {
+GURL FrameNavigationState::GetUrl(int64 frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
if (frame_state == frame_state_map_.end()) {
@@ -137,56 +102,56 @@
return frame_state->second.url;
}
-bool FrameNavigationState::IsMainFrame(FrameID frame_id) const {
- return main_frame_id_ != kInvalidFrameID && main_frame_id_ == frame_id;
+bool FrameNavigationState::IsMainFrame(int64 frame_id) const {
+ return main_frame_id_ != -1 && main_frame_id_ == frame_id;
}
-FrameNavigationState::FrameID FrameNavigationState::GetMainFrameID() const {
+int64 FrameNavigationState::GetMainFrameID() const {
return main_frame_id_;
}
-void FrameNavigationState::SetErrorOccurredInFrame(FrameID frame_id) {
+void FrameNavigationState::SetErrorOccurredInFrame(int64 frame_id) {
DCHECK(frame_state_map_.find(frame_id) != frame_state_map_.end());
frame_state_map_[frame_id].error_occurred = true;
}
-bool FrameNavigationState::GetErrorOccurredInFrame(FrameID frame_id) const {
+bool FrameNavigationState::GetErrorOccurredInFrame(int64 frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
return (frame_state == frame_state_map_.end() ||
frame_state->second.error_occurred);
}
-void FrameNavigationState::SetNavigationCompleted(FrameID frame_id) {
+void FrameNavigationState::SetNavigationCompleted(int64 frame_id) {
DCHECK(frame_state_map_.find(frame_id) != frame_state_map_.end());
frame_state_map_[frame_id].is_navigating = false;
}
-bool FrameNavigationState::GetNavigationCompleted(FrameID frame_id) const {
+bool FrameNavigationState::GetNavigationCompleted(int64 frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
return (frame_state == frame_state_map_.end() ||
!frame_state->second.is_navigating);
}
-void FrameNavigationState::SetNavigationCommitted(FrameID frame_id) {
+void FrameNavigationState::SetNavigationCommitted(int64 frame_id) {
DCHECK(frame_state_map_.find(frame_id) != frame_state_map_.end());
frame_state_map_[frame_id].is_committed = true;
}
-bool FrameNavigationState::GetNavigationCommitted(FrameID frame_id) const {
+bool FrameNavigationState::GetNavigationCommitted(int64 frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
return (frame_state != frame_state_map_.end() &&
frame_state->second.is_committed);
}
-void FrameNavigationState::SetIsServerRedirected(FrameID frame_id) {
+void FrameNavigationState::SetIsServerRedirected(int64 frame_id) {
DCHECK(frame_state_map_.find(frame_id) != frame_state_map_.end());
frame_state_map_[frame_id].is_server_redirected = true;
}
-bool FrameNavigationState::GetIsServerRedirected(FrameID frame_id) const {
+bool FrameNavigationState::GetIsServerRedirected(int64 frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
return (frame_state != frame_state_map_.end() &&

Powered by Google App Engine
This is Rietveld 408576698