Issue 10808086: Standardize log message style for cloudprint service and display printer id

Issue 10808086: Standardize log message style for cloudprint service and display printer id (Closed)

Created:
8 years, 5 months ago by Alex Yu

Modified:
8 years, 5 months ago

Reviewers:
Albert Bodenhamer

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

More Reviews

Description

Standardize log message style for cloudprint service and display printer id and job id wherever possible BUG=138602 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147987

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -97 lines)			Patch
M	chrome/service/cloud_print/cloud_print_connector.cc	View	1	6 chunks	+14 lines, -10 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_cups.cc	View	1	12 chunks	+34 lines, -21 lines	0 comments	Download
M	chrome/service/cloud_print/printer_job_handler.cc	View	1	25 chunks	+73 lines, -58 lines	0 comments	Download
M	printing/backend/print_backend_cups.cc	View	1	4 chunks	+12 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Albert Bodenhamer

lgtm http://codereview.chromium.org/10808086/diff/2001/chrome/service/cloud_print/cloud_print_connector.cc File chrome/service/cloud_print/cloud_print_connector.cc (right): http://codereview.chromium.org/10808086/diff/2001/chrome/service/cloud_print/cloud_print_connector.cc#newcode558 chrome/service/cloud_print/cloud_print_connector.cc:558: } Did you change something at EOF? If ...

8 years, 5 months ago (2012-07-23 20:49:01 UTC) #1

Alex Yu

http://codereview.chromium.org/10808086/diff/2001/chrome/service/cloud_print/cloud_print_connector.cc File chrome/service/cloud_print/cloud_print_connector.cc (right): http://codereview.chromium.org/10808086/diff/2001/chrome/service/cloud_print/cloud_print_connector.cc#newcode558 chrome/service/cloud_print/cloud_print_connector.cc:558: } On 2012/07/23 20:49:02, Albert Bodenhamer wrote: > Did ...

8 years, 5 months ago (2012-07-23 21:16:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexyu@google.com/10808086/5002

8 years, 5 months ago (2012-07-23 21:46:59 UTC) #3

Change committed as 147987

Expand Messages | Collapse Messages