Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: content/browser/renderer_host/web_input_event_aurax11.cc

Issue 10808083: gesture recognizer: Expose bounding-box for the points in a gesture-event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tot-merge Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/web_input_event_aurax11.cc
diff --git a/content/browser/renderer_host/web_input_event_aurax11.cc b/content/browser/renderer_host/web_input_event_aurax11.cc
index 9eab75a7f7d1aa4cd1900d14acd8c268e586c28d..96d124a93e903fad7e10d11f8f58fae01d219d5a 100644
--- a/content/browser/renderer_host/web_input_event_aurax11.cc
+++ b/content/browser/renderer_host/web_input_event_aurax11.cc
@@ -413,6 +413,16 @@ WebKit::WebGestureEvent MakeWebGestureEventFromAuraEvent(
gesture_event.deltaY = event->details().generic_y();
gesture_event.modifiers = EventFlagsToWebEventModifiers(event->flags());
+ // WebKit gesture events do not have bounding-boxes yet, and expect the data
+ // in deltaX/deltaY instead (and instead of bounding box, WebKit expects the
+ // radius). This is currently used only for tap events. So special case this
+ // particular case.
+ // http://crbug.com/138572
+ if (event->type() == ui::ET_GESTURE_TAP) {
+ gesture_event.deltaX = event->details().bounding_box().width() / 2;
+ gesture_event.deltaY = event->details().bounding_box().height() / 2;
+ }
+
return gesture_event;
}
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_win.cc ('k') | ui/aura/gestures/gesture_recognizer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698