Implement new volume mute button.

Implement new volume mute button.
Add a new TrayBarButtonWithTitle class which can be used for both audio and brightness UI for toggle audio/brightness state.
Clip the extra empty space around left/right bar images so that the bar image would not have too much empty space around itself.
The new audio/brightness slider will be implemented in another cl.

BUG=122832
TEST=The new mute segment should show up and work on uber tray bubble.
TBR=oshima@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148002

[sadrul, 2012-07-23 21:02:30]

http://codereview.chromium.org/10808080/diff/1/ash/system/tray/tray_views.cc
File ash/system/tray/tray_views.cc (right):

http://codereview.chromium.org/10808080/diff/1/ash/system/tray/tray_views.cc#...
ash/system/tray/tray_views.cc:513: rect.width(),
Instead of doing this, could there be a box-layout manager here (with negative
|between_child_spacing|)?

http://codereview.chromium.org/10808080/diff/1/ash/system/tray/tray_views.h
File ash/system/tray/tray_views.h (right):

http://codereview.chromium.org/10808080/diff/1/ash/system/tray/tray_views.h#n...
ash/system/tray/tray_views.h:236: explicit
TrayBarButtonWithTitle(views::ButtonListener* listener,
explicit not needed

[jennyz, 2012-07-23 21:22:03]

http://codereview.chromium.org/10808080/diff/1/ash/system/tray/tray_views.cc
File ash/system/tray/tray_views.cc (right):

http://codereview.chromium.org/10808080/diff/1/ash/system/tray/tray_views.cc#...
ash/system/tray/tray_views.cc:513: rect.width(),
On 2012/07/23 21:02:30, sadrul wrote:
> Instead of doing this, could there be a box-layout manager here (with negative
> |between_child_spacing|)?
It seems more flexible to control the layout by providing its own Layout
function here, it is similar to what boxlayout did, but easier to center the bar
image vertically  without padding the extra space with empty border.

http://codereview.chromium.org/10808080/diff/1/ash/system/tray/tray_views.h
File ash/system/tray/tray_views.h (right):

http://codereview.chromium.org/10808080/diff/1/ash/system/tray/tray_views.h#n...
ash/system/tray/tray_views.h:236: explicit
TrayBarButtonWithTitle(views::ButtonListener* listener,
On 2012/07/23 21:02:30, sadrul wrote:
> explicit not needed

Done.

[sadrul, 2012-07-23 21:39:08]

LGTM

[commit-bot: I haz the power, 2012-07-23 21:42:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/10808080/8002

[commit-bot: I haz the power, 2012-07-23 21:42:21]

Presubmit check for 10808080-8002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ash
    ui/resources

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-07-23 21:46:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennyz@chromium.org/10808080/8002

[commit-bot: I haz the power, 2012-07-24 00:32:59]

Change committed as 148002