Clang plugin: defer checking of tag decls until after top-level decl fully parsed

Clang plugin: defer checking of tag decls until after top-level decl fully parsed

It turns out that a CXXRecordDecl can change between the call to
HandleTagDeclDefinition and HandleTopLevelDecl. This happens in the
case of nested class declarations, causing us to fail to emit warnings
in some cases (see the test). See crbug.com/136863 for the full discussion.

BUG=136863
TEST=tools/clang/plugins/tests/test.sh


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148070

[hans, 2012-07-23 16:23:39]

This builds on rsleevi's investigation, and delays checking the class decls
until HandleTopLevelDecl is called. By keeping track of which declarations we
see in HandleTagDeclDefinition, we can avoid the need to walk the DeclGroupRef
tree ourselves.

Please take a look.

[Nico, 2012-07-23 17:00:09]

lgtm

[commit-bot: I haz the power, 2012-07-24 07:42:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hans@chromium.org/10808078/1

[commit-bot: I haz the power, 2012-07-24 09:01:41]

Change committed as 148070